Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use test-results-parser computed name #858

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

joseph-sentry
Copy link
Contributor

we want to use the test-results-parser computed name because it does HTML unescaping

we want to use the test-results-parser computed name because it does
HTML unescaping
Copy link

github-actions bot commented Nov 6, 2024

This PR includes changes to shared. Please review them here: https://github.com/codecov/shared/compare/83b3376fef128a8c8f4191212d89b97f3b507d15...

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (dbd2417) to head (1fedd01).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35425      -38     
==========================================
- Hits        34731    34690      -41     
- Misses        732      735       +3     
Flag Coverage Δ
integration 41.95% <100.00%> (-0.04%) ⬇️
unit 90.67% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.03%) ⬇️
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 95.26% <ø> (-1.90%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35425      -38     
==========================================
- Hits        34731    34690      -41     
- Misses        732      735       +3     
Flag Coverage Δ
integration 41.95% <100.00%> (-0.04%) ⬇️
unit 90.67% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.03%) ⬇️
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 95.26% <ø> (-1.90%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (dbd2417) to head (1fedd01).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35425      -38     
==========================================
- Hits        34731    34690      -41     
- Misses        732      735       +3     
Flag Coverage Δ
integration 41.95% <100.00%> (-0.04%) ⬇️
unit 90.67% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.03%) ⬇️
OutsideTasks 95.63% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 95.26% <ø> (-1.90%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (dbd2417) to head (1fedd01).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35425      -38     
==========================================
- Hits        34731    34690      -41     
- Misses        732      735       +3     
Flag Coverage Δ
integration 41.95% <100.00%> (-0.04%) ⬇️
unit 90.67% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.03%) ⬇️
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 95.26% <ø> (-1.90%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@joseph-sentry joseph-sentry requested a review from a team November 7, 2024 21:45
Copy link

github-actions bot commented Nov 8, 2024

This PR includes changes to shared. Please review them here: https://github.com/codecov/shared/compare/6958f32e314e6d728c1ee6a976c1cd7f49ad6f9f...

Copy link

github-actions bot commented Nov 8, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 675b8ff Nov 11, 2024
20 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-compute-name branch November 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants