Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CleanLabelsIndex task #863

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Remove CleanLabelsIndex task #863

merged 1 commit into from
Nov 8, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Nov 7, 2024

According to metrics, this task was never actually executed, so lets remove it.

@Swatinem Swatinem self-assigned this Nov 7, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         446      444       -2     
  Lines       35791    35473     -318     
==========================================
- Hits        35057    34742     -315     
+ Misses        734      731       -3     
Flag Coverage Δ
integration 97.93% <ø> (-0.01%) ⬇️
unit 97.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (-0.04%) ⬇️
OutsideTasks 97.98% <ø> (ø)
Files with missing lines Coverage Δ
tasks/__init__.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 95.58% <ø> (-0.33%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (8b1750a) to head (ebba142).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         446      444       -2     
  Lines       35791    35473     -318     
==========================================
- Hits        35057    34742     -315     
+ Misses        734      731       -3     
Flag Coverage Δ
integration 97.93% <ø> (-0.01%) ⬇️
unit 97.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (-0.04%) ⬇️
OutsideTasks 97.98% <ø> (ø)
Files with missing lines Coverage Δ
tasks/__init__.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 95.58% <ø> (-0.33%) ⬇️

Copy link

codecov-public-qa bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (8b1750a) to head (ebba142).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         446      444       -2     
  Lines       35791    35473     -318     
==========================================
- Hits        35057    34742     -315     
+ Misses        734      731       -3     
Flag Coverage Δ
integration 97.93% <ø> (-0.01%) ⬇️
unit 97.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (-0.04%) ⬇️
OutsideTasks 97.98% <ø> (ø)
Files Coverage Δ
tasks/__init__.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 95.58% <ø> (-0.33%) ⬇️

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (8b1750a) to head (ebba142).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         446      444       -2     
  Lines       35791    35473     -318     
==========================================
- Hits        35057    34742     -315     
+ Misses        734      731       -3     
Flag Coverage Δ
integration 97.93% <ø> (-0.01%) ⬇️
unit 97.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (-0.04%) ⬇️
OutsideTasks 97.98% <ø> (ø)
Files with missing lines Coverage Δ
tasks/__init__.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 95.58% <ø> (-0.33%) ⬇️

@Swatinem Swatinem force-pushed the swatinem/rm-cleanlabelindex branch from 68b0efe to 380deac Compare November 7, 2024 15:28
Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets goooo

According to metrics, this task was never actually executed, so lets remove it.
@Swatinem Swatinem force-pushed the swatinem/rm-cleanlabelindex branch from 380deac to ebba142 Compare November 8, 2024 09:04
@Swatinem Swatinem enabled auto-merge November 8, 2024 09:05
@Swatinem Swatinem added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 6819bf7 Nov 8, 2024
20 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/rm-cleanlabelindex branch November 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants