Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flip default value on upload_token_required_for_public_repos #864

Merged
merged 4 commits into from
Nov 14, 2024
Merged

flip default value on upload_token_required_for_public_repos #864

merged 4 commits into from
Nov 14, 2024

Conversation

nora-codecov
Copy link
Contributor

when true tokenless goes live we will merge this, which will make true tokenless default to "on" for new orgs.

codecov/engineering-team#2623

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

This PR includes changes to shared. Please review them here: codecov/shared@6958f32...c5a9416

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (06190da) to head (0932d9d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35412    35437   +25     
=======================================
+ Hits        34721    34746   +25     
  Misses        691      691
Flag Coverage Δ
integration 41.96% <15.38%> (-0.03%) ⬇️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (ø)
OutsideTasks 95.94% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.78% <100.00%> (ø)
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_models.py 100.00% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35412    35437   +25     
=======================================
+ Hits        34721    34746   +25     
  Misses        691      691
Flag Coverage Δ
integration 41.96% <15.38%> (-0.03%) ⬇️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (ø)
OutsideTasks 95.94% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.78% <100.00%> (ø)
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_models.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (06190da) to head (0932d9d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35412    35437   +25     
=======================================
+ Hits        34721    34746   +25     
  Misses        691      691
Flag Coverage Δ
integration 41.96% <15.38%> (-0.03%) ⬇️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (ø)
OutsideTasks 95.94% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.78% <100.00%> (ø)
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_models.py 100.00% <100.00%> (ø)

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (06190da) to head (0932d9d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35412    35437   +25     
=======================================
+ Hits        34721    34746   +25     
  Misses        691      691
Flag Coverage Δ
integration 41.96% <15.38%> (-0.03%) ⬇️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (ø)
OutsideTasks 95.94% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.78% <100.00%> (ø)
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_models.py 100.00% <100.00%> (ø)

adrian-codecov
adrian-codecov reviewed Nov 8, 2024
View reviewed changes
database/models/core.py Outdated
@@ -83,7 +83,7 @@ class Owner(CodecovBaseModel):
stripe_customer_id = Column(types.Text, server_default=FetchedValue())
stripe_subscription_id = Column(types.Text, server_default=FetchedValue())
onboarding_completed = Column(types.Boolean, default=False)
upload_token_required_for_public_repos = Column(types.Boolean, default=True)
upload_token_required_for_public_repos = Column(types.Boolean, default=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a DB default or an object default? And could we add a test that confirms this works as expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object default. With django, the default is managed in code and the db does not have a default for this field. Since it is non-nullable, worker needs to know what default to provide to the db.

In terms of the test - just a test to show that when creating an Owner the field is set to the default value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@github-actions GitHub Actions
Copy link

This PR includes changes to shared. Please review them here: codecov/shared@9a2692a...9c31870

@github-actions GitHub Actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@nora-codecov nora-codecov added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 60bf49d Nov 14, 2024
26 of 27 checks passed
@nora-codecov nora-codecov deleted the nora/2623 branch November 14, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-codecov adrian-codecov adrian-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nora-codecov @adrian-codecov