Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for Repository.updatestamp being nullable #865

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Nov 8, 2024

Fixes WORKER-Q11 which is a recent regression.

@Swatinem Swatinem requested a review from a team November 8, 2024 10:39
@Swatinem Swatinem self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (fa2ef7c) to head (deed465).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35476    35476           
=======================================
  Hits        34744    34744           
  Misses        732      732           
Flag Coverage Δ
integration 97.93% <100.00%> (ø)
unit 97.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 97.97% <ø> (ø)
Files with missing lines Coverage Δ
tasks/upload_finisher.py 95.63% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35476    35476           
=======================================
  Hits        34744    34744           
  Misses        732      732           
Flag Coverage Δ
integration 97.93% <100.00%> (ø)
unit 97.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 97.97% <ø> (ø)
Files with missing lines Coverage Δ
tasks/upload_finisher.py 95.63% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (fa2ef7c) to head (deed465).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35476    35476           
=======================================
  Hits        34744    34744           
  Misses        732      732           
Flag Coverage Δ
integration 97.93% <100.00%> (ø)
unit 97.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 97.97% <ø> (ø)
Files with missing lines Coverage Δ
tasks/upload_finisher.py 95.63% <100.00%> (ø)

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (fa2ef7c) to head (deed465).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35476    35476           
=======================================
  Hits        34744    34744           
  Misses        732      732           
Flag Coverage Δ
integration 97.93% <100.00%> (ø)
unit 97.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 97.97% <ø> (ø)
Files Coverage Δ
tasks/upload_finisher.py 95.63% <100.00%> (ø)

@Swatinem Swatinem enabled auto-merge November 8, 2024 11:24
@Swatinem Swatinem added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 742e89c Nov 8, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/null-updatestamp branch November 8, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants