Optimize Report merging #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tries to optimize the slow `Report.merge` operation. When merging report `B` into an existing report `A`, we can just use `B` in case `A` is empty. Also, the speed of merging depends on the size of the right hand size Report (`B` in this example). By swapping the reports, we can make sure to always merge the smaller Report into the larger one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 97.93% 97.93% -0.01%
==========================================
Files 444 444
Lines 35476 35475 -1
==========================================
- Hits 34744 34743 -1
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 97.93% 97.93% -0.01%
==========================================
Files 444 444
Lines 35476 35475 -1
==========================================
- Hits 34744 34743 -1
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 97.93% 97.93% -0.01%
==========================================
Files 444 444
Lines 35476 35475 -1
==========================================
- Hits 34744 34743 -1
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 97.93% 97.93% -0.01%
==========================================
Files 444 444
Lines 35476 35475 -1
==========================================
- Hits 34744 34743 -1
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| session_mapping[intermediate_report.upload_id] = new_sessionid | ||
|
|
||
| if master_report.is_empty() and old_sessionid == new_sessionid: | ||
| # if the master report is empty, we can avoid a costly merge operation |
There was a problem hiding this comment.
This happens the very first time there's an upload for a commit right?
There was a problem hiding this comment.
yes exactly, except when using carry-forwards
adrian-codecov
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to optimize the slow
Report.mergeoperation.When merging report
Binto an existing reportA, we can just useBin caseAis empty. Also, the speed of merging depends on the size of the right hand size Report (Bin this example). By swapping the reports, we can make sure to always merge the smaller Report into the larger one.