Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use read replica in cache_test_rollups #877

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/cache_test_rollups.py 80.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   97.91%   97.91%   -0.01%     
==========================================
  Files         444      444              
  Lines       35399    35403       +4     
==========================================
+ Hits        34661    34664       +3     
- Misses        738      739       +1     
Flag Coverage Δ
integration 41.87% <40.00%> (-0.01%) ⬇️
unit 90.72% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <80.00%> (-0.01%) ⬇️
OutsideTasks 95.72% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 93.02% <80.00%> (-1.85%) ⬇️

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.91%. Comparing base (5a2d60a) to head (84ded3a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/cache_test_rollups.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   97.91%   97.91%   -0.01%     
==========================================
  Files         444      444              
  Lines       35399    35403       +4     
==========================================
+ Hits        34661    34664       +3     
- Misses        738      739       +1     
Flag Coverage Δ
integration 41.87% <40.00%> (-0.01%) ⬇️
unit 90.72% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <80.00%> (-0.01%) ⬇️
OutsideTasks 95.72% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 93.02% <80.00%> (-1.85%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.91%. Comparing base (5a2d60a) to head (84ded3a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/cache_test_rollups.py 80.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   97.91%   97.91%   -0.01%     
==========================================
  Files         444      444              
  Lines       35399    35403       +4     
==========================================
+ Hits        34661    34664       +3     
- Misses        738      739       +1     
Flag Coverage Δ
integration 41.87% <40.00%> (-0.01%) ⬇️
unit 90.72% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <80.00%> (-0.01%) ⬇️
OutsideTasks 95.72% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 93.02% <80.00%> (-1.85%) ⬇️

Copy link

codecov-public-qa bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.91%. Comparing base (5a2d60a) to head (84ded3a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   97.91%   97.91%   -0.01%     
==========================================
  Files         444      444              
  Lines       35399    35403       +4     
==========================================
+ Hits        34661    34664       +3     
- Misses        738      739       +1     
Flag Coverage Δ
integration 41.87% <40.00%> (-0.01%) ⬇️
unit 90.72% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <80.00%> (-0.01%) ⬇️
OutsideTasks 95.72% <ø> (ø)
Files Coverage Δ
tasks/cache_test_rollups.py 93.02% <80.00%> (-1.85%) ⬇️

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit d71ab88 Nov 11, 2024
21 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/read-replica branch November 11, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants