Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MIME type for HTML emails #886

Merged
merged 3 commits into from
Nov 12, 2024
Merged

fix: MIME type for HTML emails #886

merged 3 commits into from
Nov 12, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Our emails were adding an extra text/ to the text/html MIME type on our emails, causing only the text content to display in gmail web client (though mailhog handled this fine interestingly).

Also adds "Codecov" as the display name for our emails.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review November 12, 2024 21:46
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (96d99ca) to head (8fea409).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708
Flag Coverage Δ
integration 41.95% <100.00%> (ø)
unit 90.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (ø)
OutsideTasks 95.86% <100.00%> (ø)
Files with missing lines Coverage Δ
helpers/email.py 100.00% <100.00%> (ø)
tasks/send_email.py 100.00% <ø> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (96d99ca) to head (8fea409).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708
Flag Coverage Δ
integration 41.95% <100.00%> (ø)
unit 90.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (ø)
OutsideTasks 95.86% <100.00%> (ø)
Files with missing lines Coverage Δ
helpers/email.py 100.00% <100.00%> (ø)
tasks/send_email.py 100.00% <ø> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708
Flag Coverage Δ
integration 41.95% <100.00%> (ø)
unit 90.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (ø)
OutsideTasks 95.86% <100.00%> (ø)
Files with missing lines Coverage Δ
helpers/email.py 100.00% <100.00%> (ø)
tasks/send_email.py 100.00% <ø> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)

@github-actions GitHub Actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (96d99ca) to head (8fea409).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708
Flag Coverage Δ
integration 41.95% <100.00%> (ø)
unit 90.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (ø)
OutsideTasks 95.86% <100.00%> (ø)
Files with missing lines Coverage Δ
helpers/email.py 100.00% <100.00%> (ø)
tasks/send_email.py 100.00% <ø> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)

ajay-sentry
ajay-sentry reviewed Nov 12, 2024
View reviewed changes
tasks/tests/integration/test_send_email_task.py
@@ -79,7 +79,7 @@ def test_send_email_integration(
"",
]
assert mail_body[7:-1] == [
'Content-Type: text/text/html; charset="utf-8"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buh

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit b6854d4 Nov 12, 2024
26 of 27 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/send-email-fixes branch November 12, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalmurray-codecov @ajay-sentry