Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log usage of niche features #893

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Log usage of niche features #893

merged 1 commit into from
Nov 14, 2024

Conversation

Swatinem
Copy link
Contributor

This adds Sentry capture_message to some rarely-used features, in order to help decide what to do about these.

This adds Sentry `capture_message` to some rarely-used features, in order to help decide what to do about these.
@Swatinem Swatinem requested a review from a team November 14, 2024 10:56
@Swatinem Swatinem self-assigned this Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.04%. Comparing base (e5095d3) to head (98701d6).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/upload.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   98.05%   98.04%   -0.01%     
==========================================
  Files         444      444              
  Lines       35394    35399       +5     
==========================================
+ Hits        34704    34708       +4     
- Misses        690      691       +1     
Flag Coverage Δ
integration 41.96% <33.33%> (+<0.01%) ⬆️
unit 90.85% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <66.66%> (-0.01%) ⬇️
OutsideTasks 95.93% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/report/raw_upload_processor.py 98.93% <100.00%> (+0.01%) ⬆️
tasks/upload.py 96.24% <50.00%> (-0.32%) ⬇️

... and 5 files with indirect coverage changes

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/upload.py 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   98.05%   98.04%   -0.01%     
==========================================
  Files         444      444              
  Lines       35394    35399       +5     
==========================================
+ Hits        34704    34708       +4     
- Misses        690      691       +1     
Flag Coverage Δ
integration 41.96% <33.33%> (+<0.01%) ⬆️
unit 90.85% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <66.66%> (-0.01%) ⬇️
OutsideTasks 95.93% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/report/raw_upload_processor.py 98.93% <100.00%> (+0.01%) ⬆️
tasks/upload.py 96.24% <50.00%> (-0.32%) ⬇️

... and 5 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.04%. Comparing base (e5095d3) to head (98701d6).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/upload.py 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   98.05%   98.04%   -0.01%     
==========================================
  Files         444      444              
  Lines       35394    35399       +5     
==========================================
+ Hits        34704    34708       +4     
- Misses        690      691       +1     
Flag Coverage Δ
integration 41.96% <33.33%> (+<0.01%) ⬆️
unit 90.85% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <66.66%> (-0.01%) ⬇️
OutsideTasks 95.93% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/report/raw_upload_processor.py 98.93% <100.00%> (+0.01%) ⬆️
tasks/upload.py 96.24% <50.00%> (-0.32%) ⬇️

... and 5 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.04%. Comparing base (e5095d3) to head (98701d6).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/upload.py 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   98.05%   98.04%   -0.01%     
==========================================
  Files         444      444              
  Lines       35394    35399       +5     
==========================================
+ Hits        34704    34708       +4     
- Misses        690      691       +1     
Flag Coverage Δ
integration 41.96% <33.33%> (+<0.01%) ⬆️
unit 90.85% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <66.66%> (-0.01%) ⬇️
OutsideTasks 95.93% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/report/raw_upload_processor.py 98.93% <100.00%> (+0.01%) ⬆️
tasks/upload.py 96.24% <50.00%> (-0.32%) ⬇️

... and 5 files with indirect coverage changes

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem Swatinem added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 20861f4 Nov 14, 2024
20 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/log-features branch November 14, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants