Do not trigger Notify twice from TestResultsFinisher

[Swatinem]

This also fixes up the return value in case the test results comment was updates.

Plus, it does a little formatting and typing cleanup.

[joseph-sentry]

good catch!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (c20baed) to head (bc5307f).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3     

Flag	Coverage Δ
integration	41.93% <100.00%> (-0.03%)	⬇️
unit	90.87% <20.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.16% <100.00%> (+0.02%)	⬆️
OutsideTasks	95.95% <ø> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
tasks/test_results_finisher.py	93.52% <100.00%> (-0.08%)	⬇️
tasks/tests/unit/test_test_results_finisher.py	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3     

Flag	Coverage Δ
integration	41.93% <100.00%> (-0.03%)	⬇️
unit	90.87% <20.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.16% <100.00%> (+0.02%)	⬆️
OutsideTasks	95.95% <ø> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
tasks/test_results_finisher.py	93.52% <100.00%> (-0.08%)	⬇️
tasks/tests/unit/test_test_results_finisher.py	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

[codecov-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (c20baed) to head (bc5307f).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3     

Flag	Coverage Δ
integration	41.93% <100.00%> (-0.03%)	⬇️
unit	90.87% <20.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.16% <100.00%> (+0.02%)	⬆️
OutsideTasks	95.95% <ø> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
tasks/test_results_finisher.py	93.52% <100.00%> (-0.08%)	⬇️
tasks/tests/unit/test_test_results_finisher.py	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

[codecov-public-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (c20baed) to head (bc5307f).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3     

Flag	Coverage Δ
integration	41.93% <100.00%> (-0.03%)	⬇️
unit	90.87% <20.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.16% <100.00%> (+0.02%)	⬆️
OutsideTasks	95.95% <ø> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
tasks/test_results_finisher.py	93.52% <100.00%> (-0.08%)	⬇️
tasks/tests/unit/test_test_results_finisher.py	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

[github-actions]

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov