Enable timeseries for local testing environment #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the `Skipping timeseries migration` logs are due to the fact that a timeseries database is configured (by default) but it's not enabled, which doesn't trigger the migration and hence the warning. We _could_ probably also remove the warning, as it's kind of noisy. But this is quicker, because the warning is in `shared`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 444 446 +2
Lines 35540 35608 +68
=======================================
+ Hits 34835 34902 +67
- Misses 705 706 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Swatinem
approved these changes
Nov 20, 2024
michelletran-codecov
deleted the
ensure_timeseries_migrations_in_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the
Skipping timeseries migrationlogs are due to the fact that a timeseries database is configured (by default) but it's not enabled, which doesn't trigger the migration and hence the warning. We could probably also remove the warning, as it's kind of noisy. But this is quicker, because the warning is inshared.I could also be convinced to just set line 207 to hardcode
TIMESERIES_ENABLED=true(this will affect the tests in CI, but this doesn't really affect test runs).BTW, running the tests on the
umbrella-hatversion of worker doesn't have this issue because the configuration inumbrella-hatsetstimeseriesto be enabled.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.