Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove new feature comment section #907

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Nov 20, 2024

this change also includes a change to the profiling normalizer because
it was breaking the linter

@joseph-sentry joseph-sentry requested a review from a team November 20, 2024 21:45
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (ff51806) to head (0d0d601).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.02%     
==========================================
  Files         446      446              
  Lines       35636    35598      -38     
==========================================
- Hits        34921    34880      -41     
- Misses        715      718       +3     
Flag Coverage Δ
integration 42.01% <0.00%> (+0.02%) ⬆️
unit 90.83% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

this change also includes a change to the profiling normalizer because
it was breaking the linter
@joseph-sentry joseph-sentry changed the title fix: promo message format and conditions fix: remove new feature comment section Nov 22, 2024
@joseph-sentry joseph-sentry requested a review from a team November 22, 2024 15:33
@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 426a499 Nov 22, 2024
20 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-comment-format branch November 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants