Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight ParsedRawReport cleanup #932

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Slight ParsedRawReport cleanup #932

merged 1 commit into from
Dec 3, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Dec 3, 2024

Removes a bunch of has/get methods in favor of accessing fields directly. Removes the env field completely.
Avoids a BytesIO indirection in the renamed as_readable method.

@Swatinem Swatinem requested a review from a team December 3, 2024 12:30
@Swatinem Swatinem self-assigned this Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.97%. Comparing base (dcf7304) to head (3ba6405).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/processing/processing.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   97.97%   97.97%   -0.01%     
==========================================
  Files         446      446              
  Lines       35657    35606      -51     
==========================================
- Hits        34935    34884      -51     
  Misses        722      722
Flag Coverage Δ
integration 42.09% <33.33%> (+<0.01%) ⬆️
unit 90.64% <98.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/processing/processing.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

giovanni-guidini
giovanni-guidini approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well LGTM, but truth is I don't have too much context on this part of the code.

I left some questions, but they seem nit-level

services/report/parser/legacy.py Outdated Show resolved Hide resolved
services/report/parser/types.py Show resolved Hide resolved
services/report/parser/legacy.py
return LegacyParsedRawReport(
toc=toc_section,
env=env_section,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we have to update documentation by removing this?
(Not against the removal, just trying to be helpful)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which documentation do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha good point. I looked for docs mentioning this "env" options in the uploads but found none.

The only place you'd find is running --help on the do-upload command of the CLI honestly

@Swatinem
Slight ParsedRawReport cleanup
3ba6405 
Removes a bunch of has/get methods in favor of accessing fields directly.
Removes the `env` field completely.
Avoids a `BytesIO` indirection in the renamed `as_readable` method.
@Swatinem Swatinem force-pushed the swatinem/rawreport-env-bytes branch from 6ba6bba to 3ba6405 Compare December 3, 2024 14:38
@Swatinem Swatinem added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 1d68d39 Dec 3, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/rawreport-env-bytes branch December 3, 2024 15:18
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 3, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

trent-codecov added a commit that referenced this pull request Dec 3, 2024
@trent-codecov
Revert "Slight ParsedRawReport cleanup (#932)"
ad2ac21 
This reverts commit 1d68d39.
@trent-codecov trent-codecov mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @giovanni-guidini