Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve test results processing task #938

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

  • fixes a bug when the parsed duration is none
  • adds typing to the daily_totals dictionary in bulk_write_tests_to_db

@joseph-sentry joseph-sentry requested a review from a team December 4, 2024 14:31
@joseph-sentry joseph-sentry marked this pull request as draft December 4, 2024 14:31
Copy link

sentry-io bot commented Dec 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/test_results_processor.py

Function Unhandled Issue
_bulk_write_tests_to_db TypeError: unsupported operand type(s) for *: 'NoneType' and 'int' app.tasks.test_results.Te...
Event Count: 3

Did you find this useful? React with a 👍 or 👎

Copy link

github-actions bot commented Dec 4, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (612025f) to head (e3c5bf2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         445      445           
  Lines       35705    35754   +49     
=======================================
+ Hits        34985    35034   +49     
  Misses        720      720           
Flag Coverage Δ
integration 42.11% <100.00%> (+0.07%) ⬆️
unit 90.62% <37.25%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@joseph-sentry joseph-sentry marked this pull request as ready for review December 4, 2024 16:03
@joseph-sentry joseph-sentry added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit a723522 Dec 4, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-ta branch December 4, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants