Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove test count query from sync pull #974

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

this query is really expensive on the database so let's just remove it

this query is really expensive on the database so let's just remove it
@joseph-sentry joseph-sentry requested a review from a team December 19, 2024 16:24
@codecov-notifications
Copy link

codecov-notifications bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (232a065) to head (5a0f7a9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   97.97%   97.97%   -0.01%     
==========================================
  Files         444      444              
  Lines       35859    35853       -6     
==========================================
- Hits        35133    35127       -6     
  Misses        726      726              
Flag Coverage Δ
integration 42.16% <33.33%> (+<0.01%) ⬆️
unit 90.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@joseph-sentry joseph-sentry added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit e7a2e1c Dec 19, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-query branch December 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants