fix: handle empty/windows paths correctly in base-path-aware path fixer #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 444 444
Lines 35850 35873 +23
=======================================
+ Hits 35124 35147 +23
Misses 726 726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
- the regular path fixer early-exits if the passed-in path is `""` - if the regular path fixer doesn't succeed, the base-aware path fixer retries with some prefixes (one of them being `./`) - the regular path fixer is retried with the passed-in path of `""`, so it does not early-exit - however, the next line strips `./` so the path is _turned into_ `""` - `os.path.relpath()` gets mad
matt-codecov
force-pushed
the
matt/fix-base-aware-pathfixer
branch
from
38aeb0c to
038ae62
Compare
matt-codecov
changed the title
adrian-codecov
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are a couple issues in the base-path-aware path fixer:
empty paths are not skipped
""./for windows paths due to the other bug fixed in this PR)"", so it does not early-exit./so the path is turned into""os.path.relpath()gets madincorrect usage of
PurePaththe base-path-aware path fixer uses the parent directory of the coverage file as its base. we use
PurePathto figure out that parent directory, as it does not perform any actual disk operations, it's just path manipulations.the issue is,
PurePathon our Linux prod servers will instantiate aPurePosixPath, even if the path we are using is clearly a windows path likeC:\Users\matt. this is wrong:the fix is to use
PureWindowsPathfor windows paths andPurePosixPathotherwiseLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.