generated from codecrafters-io/tester-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor custom checks with DescribeTopicPartitionsResponseAssertion
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-gang
changed the title
Refactor DescribeTopicPartition to DescribeTopicPartitions
Refactor custom checks with Oct 1, 2024
DescribeTopicPartitionAssertion
ryan-gang
changed the title
Refactor custom checks with
Refactor custom checks with Oct 1, 2024
DescribeTopicPartitionAssertion
DescribeTopicPartitionsResponseAssertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new assertion type and refactors existing tests to use this new assertion for Kafka topic partition responses. The most important changes include the addition of the
DescribeTopicPartitionsResponseAssertion
type, updates to existing test functions to use this new assertion, and the addition of a new test function.New Assertion Type:
internal/assertions/describe_topic_assertion.go
: AddedDescribeTopicPartitionsResponseAssertion
type for validating Kafka topic partition responses.Refactoring Existing Tests:
internal/stagep2.go
: Updated thetestDTPartitionWithUnknownTopic
function to useDescribeTopicPartitionsResponseAssertion
for response validation. [1] [2] [3]internal/stagep3.go
: Updated thetestDTPartitionWithTopicAndSinglePartition
function to useDescribeTopicPartitionsResponseAssertion
for response validation. [1] [2] [3]New Test Function:
internal/stagep4.go
: Added a new test functiontestDTPartitionWithTopicAndMultiplePartitions2
to validate responses for topics with multiple partitions using the new assertion type.Minor Refactor:
internal/stagep5.go
: Renamed the test function totestDTPartitionWithTopics
and removed redundant error handling forGenerateLogDirs
. [1] [2]