Skip to content

Fixing-aws-acl-condition #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

Fixing-aws-acl-condition #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/aws/aws_cloudfront_distribution/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ansible.builtin.include_role:
name: aws/aws_acl
when:
- aws_acl is defined
- aws_acl.scope is defined
- aws_acl.scope == 'CLOUDFRONT'

# Creating bucket for CF logging
Expand Down
2 changes: 1 addition & 1 deletion roles/aws/aws_elb/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@

- name: Add HTTP listeners.
ansible.builtin.set_fact:
_aws_ec2_listeners: "{{ [ _aws_ec2_listeners_http ] }}"

Check warning on line 97 in roles/aws/aws_elb/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Lint the codebase

jinja[spacing] 

Jinja2 spacing could be improved: {{ [ _aws_ec2_listeners_http ] }} -> {{ [_aws_ec2_listeners_http] }}
when: _ssl_certificate_ARN | length < 1

- name: Add HTTPS Listener.
ansible.builtin.set_fact:
_aws_ec2_listeners: "{{ [ _aws_ec2_listeners_redirect, _aws_ec2_listeners_https ] }}"

Check warning on line 102 in roles/aws/aws_elb/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Lint the codebase

jinja[spacing] 

Jinja2 spacing could be improved: {{ [ _aws_ec2_listeners_redirect, _aws_ec2_listeners_https ] }} -> {{ [_aws_ec2_listeners_redirect, _aws_ec2_listeners_https] }}
when: _ssl_certificate_ARN | length > 1

- name: Add custom Listeners.
Expand Down Expand Up @@ -139,7 +139,7 @@
ansible.builtin.include_role:
name: aws/aws_acl
when:
- aws_acl is defined
- aws_acl.scope is defined
- aws_acl.scope == 'REGIONAL'

- name: Get ALB listener ARN for port 443.
Expand Down
Loading