day 1 #3
Open
day 1 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broxsonl
reviewed
Feb 16, 2017
| @@ -0,0 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const greet = require('./lib/greet.js'); | |||
|
|
||
| greet.sayHi('Gary'); | ||
| greet.sayBye(); | ||
| greet.greetStranger(); |
There was a problem hiding this comment.
Nice third function call here for the input method.
|
|
||
| module.exports = exports = {}; | ||
|
|
||
| var strangerName = process.argv[2]; |
There was a problem hiding this comment.
Good work storing this in a semantic variable to make it easier to use later.
| }; | ||
|
|
||
| exports.greetStranger = function() { | ||
| console.log(`Hi there, ${strangerName}!`); |
There was a problem hiding this comment.
Much easier to pass the variable you made in here than the process.argv line you otherwise would have had to. It's much more human readable.
| }; | ||
|
|
||
| exports.greetStranger = function() { | ||
| console.log(`Hi there, ${strangerName}!`); |
| assert.ok(bye === 'See you later!', 'not equal to See you later!'); | ||
| }); | ||
| }); | ||
| // attempt to test my command line argument, not sure how to do it. |
There was a problem hiding this comment.
You would probably want to use process.argv here in your test and make sure the user input from the CLI lines up here. You'd need to basically manually set the name here into the process.argv array to be used in the function when it's called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done