-
Notifications
You must be signed in to change notification settings - Fork 15
lab-dana #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
lab-dana #17
Changes from all commits
ce05b03
403cea6
cfc9dd1
8022056
fcf310b
ef660dc
8c78336
0dc917c
0645f76
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
# Created by https://www.gitignore.io/api/node,vim,osx,macos,linux | ||
|
||
*node_modules | ||
|
||
### Node ### | ||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
|
||
# Runtime data | ||
pids | ||
*.pid | ||
*.seed | ||
*.pid.lock | ||
|
||
# Directory for instrumented libs generated by jscoverage/JSCover | ||
lib-cov | ||
|
||
# Coverage directory used by tools like istanbul | ||
coverage | ||
|
||
# nyc test coverage | ||
.nyc_output | ||
|
||
# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) | ||
.grunt | ||
|
||
# node-waf configuration | ||
.lock-wscript | ||
|
||
# Compiled binary addons (http://nodejs.org/api/addons.html) | ||
build/Release | ||
|
||
# Dependency directories | ||
node_modules | ||
jspm_packages | ||
|
||
# Optional npm cache directory | ||
.npm | ||
|
||
# Optional eslint cache | ||
.eslintcache | ||
|
||
# Optional REPL history | ||
.node_repl_history | ||
|
||
# Output of 'npm pack' | ||
*.tgz | ||
|
||
# Yarn Integrity file | ||
.yarn-integrity | ||
|
||
|
||
|
||
### Vim ### | ||
# swap | ||
[._]*.s[a-v][a-z] | ||
[._]*.sw[a-p] | ||
[._]s[a-v][a-z] | ||
[._]sw[a-p] | ||
# session | ||
Session.vim | ||
# temporary | ||
.netrwhist | ||
*~ | ||
# auto-generated tag files | ||
tags | ||
|
||
|
||
### OSX ### | ||
*.DS_Store | ||
.AppleDouble | ||
.LSOverride | ||
|
||
# Icon must end with two \r | ||
Icon | ||
# Thumbnails | ||
._* | ||
# Files that might appear in the root of a volume | ||
.DocumentRevisions-V100 | ||
.fseventsd | ||
.Spotlight-V100 | ||
.TemporaryItems | ||
.Trashes | ||
.VolumeIcon.icns | ||
.com.apple.timemachine.donotpresent | ||
# Directories potentially created on remote AFP share | ||
.AppleDB | ||
.AppleDesktop | ||
Network Trash Folder | ||
Temporary Items | ||
.apdisk | ||
|
||
|
||
### macOS ### | ||
# Icon must end with two \r | ||
# Thumbnails | ||
# Files that might appear in the root of a volume | ||
# Directories potentially created on remote AFP share | ||
|
||
|
||
### Linux ### | ||
|
||
# temporary files which can be created if a process still has a handle open of a deleted file | ||
.fuse_hidden* | ||
|
||
# KDE directory preferences | ||
.directory | ||
|
||
# Linux trash folder which might appear on any partition or disk | ||
.Trash-* | ||
|
||
# .nfs files are created when an open file is removed but is still being accessed | ||
.nfs* | ||
|
||
# End of https://www.gitignore.io/api/node,vim,osx,macos,linux |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
'use strict'; | ||
|
||
const gulp = require('gulp'); | ||
const eslint = require('gulp-eslint'); | ||
const mocha = require('gulp-mocha'); | ||
|
||
gulp.task('lint', function() { | ||
return gulp.src(['**/*.js', '!node_modules']) | ||
.pipe(eslint()) | ||
.pipe(eslint.format()) | ||
.pipe(eslint.failAfterError()); | ||
}); | ||
|
||
gulp.task('test', function() { | ||
gulp.src('./test/*-test.js', { read: false }) | ||
.pipe(mocha({ reporter: 'spec'})); | ||
}); | ||
|
||
gulp.task('dev', function() { | ||
gulp.watch(['**/*.js', '!node_modules'], ['lint', 'test']); | ||
}); | ||
|
||
gulp.task('default', ['dev']); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice work writing a default gulp task to run all of your other gulp tasks. :) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
'use strict'; | ||
|
||
const welcome = require('./lib/howdy.js'); | ||
|
||
if (process.argv.length < 3) throw new Error('please enter a name!'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice validation! This was a fun thing to look at when we looked at it. :D |
||
|
||
if (process.argv.length === 3) welcome.greeting(process.argv[2]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool! If the length is three, then call greet with a name passed in. |
||
|
||
if (process.argv.length > 3) welcome.multipleGreetings(process.argv); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AWESOME job writing a method to be able to deal with multiple user inputs. 🗡 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'use strict'; | ||
|
||
module.exports = exports = {}; | ||
|
||
exports.greeting = function(name) { | ||
if (arguments.length === 0) throw new Error('no name given'); | ||
console.log(`What's up, ${name}?!`); | ||
return `hello ${name}`; | ||
}; | ||
|
||
exports.multipleGreetings = function(termInput) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Phenomenal logic here. :) Really a fan of being able to handle multiple inputs like this! |
||
let names = termInput.slice(2); | ||
let logMessage = ' '; | ||
logMessage += names.slice(0, -1).join(', '); | ||
logMessage += (' and '); | ||
logMessage += names.slice(-1).join(''); | ||
logMessage += ('!'); | ||
console.log(`Hey there ${logMessage}`); | ||
return `Hey there ${logMessage}`; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
{ | ||
"name": "02-build_automation_and_dependency_management", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could put your name in here instead. |
||
"version": "1.0.0", | ||
"description": " Lab 02: Build Automation & Dependency Management ===", | ||
"main": "index.js", | ||
"directories": { | ||
"test": "test" | ||
}, | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/dkulp23/02-build_automation_and_dependency_management.git" | ||
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC", | ||
"bugs": { | ||
"url": "https://github.com/dkulp23/02-build_automation_and_dependency_management/issues" | ||
}, | ||
"homepage": "https://github.com/dkulp23/02-build_automation_and_dependency_management#readme", | ||
"dependencies": { | ||
"express": "^4.14.1" | ||
}, | ||
"devDependencies": { | ||
"chai": "^3.5.0", | ||
"gulp": "^3.9.1", | ||
"gulp-eslint": "^3.0.1", | ||
"gulp-mocha": "^3.0.1", | ||
"mocha": "^3.2.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
'use strict'; | ||
|
||
const howdy = require('../lib/howdy.js'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Heh. Love that you named the module howdy. |
||
const expect = require('chai').expect; | ||
|
||
describe('Howdy Module', function() { | ||
describe('#greeting', function() { | ||
it(`should return hello ${process.argv[2]}`, function() { | ||
let printout = howdy.greeting(process.argv[2]); | ||
expect(howdy).to.have.property('greeting'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Phenomenal use of different chai methods below. :) Great work! |
||
expect(howdy).to.be.extensible; | ||
expect(howdy).to.not.be.sealed; | ||
expect(howdy).to.not.be.frozen; | ||
expect(printout).to.match(/^[a-zA-Z,!\s]+/); | ||
expect(printout).to.eql(`hello ${process.argv[2]}`); | ||
}); | ||
|
||
it('Should result in error from missing input', function() { | ||
let fn = howdy.greeting; | ||
expect(fn).to.throw(Error); | ||
}); | ||
}); | ||
|
||
describe('#multipleGreetings', function() { | ||
it('should return all names entered in command line', function() { | ||
expect(howdy).to.respondTo('multipleGreetings'); | ||
let printout = howdy.multipleGreetings(process.argv); | ||
expect(printout).to.be.a('string'); | ||
expect(printout).to.match(/^[a-zA-Z,!\s]+/); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great use of regex to ensure the validity of the user input here! |
||
}); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work ignoring node modules.