-
Notifications
You must be signed in to change notification settings - Fork 15
lab-shiv #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
lab-shiv #21
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
# Created by https://www.gitignore.io/api/node,vim,osx,macos,linux | ||
|
||
*node_modules | ||
|
||
### Node ### | ||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
|
||
# Runtime data | ||
pids | ||
*.pid | ||
*.seed | ||
*.pid.lock | ||
|
||
# Directory for instrumented libs generated by jscoverage/JSCover | ||
lib-cov | ||
|
||
# Coverage directory used by tools like istanbul | ||
coverage | ||
|
||
# nyc test coverage | ||
.nyc_output | ||
|
||
# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) | ||
.grunt | ||
|
||
# node-waf configuration | ||
.lock-wscript | ||
|
||
# Compiled binary addons (http://nodejs.org/api/addons.html) | ||
build/Release | ||
|
||
# Dependency directories | ||
node_modules | ||
jspm_packages | ||
|
||
# Optional npm cache directory | ||
.npm | ||
|
||
# Optional eslint cache | ||
.eslintcache | ||
|
||
# Optional REPL history | ||
.node_repl_history | ||
|
||
# Output of 'npm pack' | ||
*.tgz | ||
|
||
# Yarn Integrity file | ||
.yarn-integrity | ||
|
||
|
||
|
||
### Vim ### | ||
# swap | ||
[._]*.s[a-v][a-z] | ||
[._]*.sw[a-p] | ||
[._]s[a-v][a-z] | ||
[._]sw[a-p] | ||
# session | ||
Session.vim | ||
# temporary | ||
.netrwhist | ||
*~ | ||
# auto-generated tag files | ||
tags | ||
|
||
|
||
### OSX ### | ||
*.DS_Store | ||
.AppleDouble | ||
.LSOverride | ||
|
||
# Icon must end with two \r | ||
Icon | ||
# Thumbnails | ||
._* | ||
# Files that might appear in the root of a volume | ||
.DocumentRevisions-V100 | ||
.fseventsd | ||
.Spotlight-V100 | ||
.TemporaryItems | ||
.Trashes | ||
.VolumeIcon.icns | ||
.com.apple.timemachine.donotpresent | ||
# Directories potentially created on remote AFP share | ||
.AppleDB | ||
.AppleDesktop | ||
Network Trash Folder | ||
Temporary Items | ||
.apdisk | ||
|
||
|
||
### macOS ### | ||
# Icon must end with two \r | ||
# Thumbnails | ||
# Files that might appear in the root of a volume | ||
# Directories potentially created on remote AFP share | ||
|
||
|
||
### Linux ### | ||
|
||
# temporary files which can be created if a process still has a handle open of a deleted file | ||
.fuse_hidden* | ||
|
||
# KDE directory preferences | ||
.directory | ||
|
||
# Linux trash folder which might appear on any partition or disk | ||
.Trash-* | ||
|
||
# .nfs files are created when an open file is removed but is still being accessed | ||
.nfs* | ||
|
||
# End of https://www.gitignore.io/api/node,vim,osx,macos,linux |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
'use strict'; | ||
|
||
const gulp = require('gulp'); | ||
const eslint = require('gulp-eslint'); | ||
const mocha = require('gulp-mocha'); | ||
|
||
gulp.task('test', function() { | ||
gulp.src('./test/*-test.js', {read: false}) | ||
.pipe(mocha({reporter: 'nyan'})) | ||
}) | ||
|
||
gulp.task('lint', function() { | ||
return gulp.src(['**/*.js', '!node_modules']) | ||
.pipe(eslint()) | ||
.pipe(eslint.format()) | ||
.pipe(eslint.failAfterError()); | ||
}) | ||
|
||
gulp.task('dev', function() { | ||
gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']); | ||
}) | ||
|
||
gulp.task('default', ['dev']); | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
'use strict'; // every single file | ||
|
||
const greet = require('./lib/greet.js'); // define the variable where you are defining the path | ||
greet.sayHey = ('shiv'); // sayHey is a function of this file, and I am passing in the parameter of shiv to it. | ||
greet.sayBye(); // calling the function, but it does not take in any parameters. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// 'use strict'; // every single file | ||
// | ||
// const greet = require('./lib/greet.js'); // define the variable where you are defining the path | ||
// greet.sayHey = ('shiv'); // sayHey is a function of this file, and I am passing in the parameter of shiv to it. | ||
// greet.sayBye(); // calling the function, but it does not take in any parameters. | ||
|
||
//////////// MISTAKE ////////////////////// | ||
// MAKE SURE THAT THIS INFORMATION GOES ON THE INDEX.JS FILE, NOT THE GREET.JS FILE. | ||
|
||
'use strict'; | ||
module.exports = exports = {}; | ||
|
||
exports.sayHey = function(name) { | ||
if (arguments.length === 0) throw new Error ('name not provided!'); | ||
return `Hey ${name}!`; | ||
} | ||
|
||
exports.sayBye = function() { | ||
return 'see ya later!'; // for some reason, this doesn't need parameters. | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't need parameters because it doesn't use parameters. If you wanted it to say 'see ya later Shiv!' you could construct it similar to the other method and make it take 'Shiv' as a parameter. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"name": "lab-shiv", | ||
"version": "1.0.0", | ||
"description": "", | ||
"main": "index.js", | ||
"directories": { | ||
"test": "test" | ||
}, | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC", | ||
"devDependencies": { | ||
"chai": "^3.5.0", | ||
"gulp": "^3.9.1", | ||
"gulp-eslint": "^3.0.1", | ||
"gulp-mocha": "^4.0.1", | ||
"mocha": "^3.2.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict'; | ||
|
||
const greet = require('../lib/greet.js'); | ||
const expect = require('chai').expect; | ||
|
||
describe('Greet Module', function() { | ||
describe('#sayHey', function() { | ||
it('should be returning Hey Shiv!', function() { | ||
var result = greet.sayHey('Shiv'); | ||
expect(greet).to.have.property('sayHey'); | ||
expect(result).to.equal('Hey Shiv!'); | ||
}); | ||
it('should throw a missing error name', function() { | ||
var result = greet.sayHey; | ||
expect(result).to.throw(Error); | ||
}); | ||
}); | ||
describe('#sayBye', function() { | ||
it('should return see ya later!', function() { | ||
var result = greet.sayBye(); | ||
expect(result).to.equal('see ya later!'); | ||
}); | ||
}); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good Job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job with your gulpfile.