Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bunch of stuff, not really working #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
# "linebreak-style": [ "error", "unix" ],
"linebreak-style": [ "error", "windows"]
},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
122 changes: 122 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@

# Created by https://www.gitignore.io/api/monodevelop,vim,node,windows,archlinuxpackages

### ArchLinuxPackages ###
*.tar
*.tar.*
*.jar
*.exe
*.msi
*.zip
*.tgz
*.log
*.log.*
*.sig

pkg/
src/

### MonoDevelop ###
#User Specific
*.userprefs
*.usertasks

#Mono Project Files
*.pidb
*.resources
test-results/

### Node ###
# Logs
logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Typescript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env


### Vim ###
# swap
[._]*.s[a-v][a-z]
[._]*.sw[a-p]
[._]s[a-v][a-z]
[._]sw[a-p]
# session
Session.vim
# temporary
.netrwhist
*~
# auto-generated tag files
tags

### Windows ###
# Windows thumbnail cache files
Thumbs.db
ehthumbs.db
ehthumbs_vista.db

# Folder config file
Desktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msm
*.msp

# Windows shortcuts
*.lnk

# End of https://www.gitignore.io/api/monodevelop,vim,node,windows,archlinuxpackages
1 change: 1 addition & 0 deletions data/one.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cayla and Jeremiah are sitting on the other side of the desk.
1 change: 1 addition & 0 deletions data/three.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
We are loving 401 so far!
1 change: 1 addition & 0 deletions data/two.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The lighting here can be a bit annoying.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. Yeah, it can.

23 changes: 23 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'use strict';

const gulp = require('gulp');
const eslint = require('gulp-eslint');
const mocha = require('gulp-mocha');

gulp.task('test', function () {
gulp.src('./test/*-test.js', { read: false})
.pipe(mocha({reporter: 'spec'}));
});

gulp.task('lint', function() {
return gulp.src(['**/*.js', '!node_modules'])
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

gulp.task('dev', function() {
gulp.watch(['**/*.js', '!node_modules'], ['lint', 'test']);
});

gulp.task('default', ['dev']);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work including your gulp file.

9 changes: 9 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

const fs = require('fs');
const fileReader = require('./lib/file-reader.js');


fileReader('./data/one.txt', callback);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your index file, you're calling fileReader on your first txt file.

With the way you structured your fileReader module, it will statically read file2 and file3 after...but it'd be best to make this more dynamic.

You can call this function with the three txt files, and dynamically have them be passed into the function in your file reader module in the other script.


// TODO: I want this to send my file reader the first path and start it reading my text files, then get a array of results and log them here.
22 changes: 22 additions & 0 deletions lib/file-reader.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
'use strict';

const fs = require('fs');

const fileReader = module.exports = function(pathArray, callback) {
var fileArray = [];

fs.readFile(pathArray[0], function(err, data) {
if(err) return callback(err);
fileArray.push(data.toString('hex', 0, 8));
fs.readFile(pathArray[1], function(err, data) {
if(err) return callback(err);
fileArray.push(data.toString('hex', 0, 8));
fs.readFile(pathArray[2], function(err, data) {
if(err) return callback(err);
fileArray.push(data.toString('hex', 0, 8));
console.log('my read file result:', fileArray);
return callback(null, fileArray);
});
});
});
};
27 changes: 27 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"name": "03-parallel_file_processing",
"version": "1.0.0",
"description": "![CF](https://camo.githubusercontent.com/70edab54bba80edb7493cad3135e9606781cbb6b/687474703a2f2f692e696d6775722e636f6d2f377635415363382e706e67) Lab 03: Parallel File Processing\r ===",
"main": "index.js",
"directories": {
"test": "test"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"repository": {
"type": "git",
"url": "git+https://github.com/GLSea1979/03-parallel_file_processing.git"
},
"keywords": [],
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/GLSea1979/03-parallel_file_processing/issues"
},
"homepage": "https://github.com/GLSea1979/03-parallel_file_processing#readme",
"devDependencies": {
"chai": "^3.5.0",
"mocha": "^3.2.0"
}
}
34 changes: 34 additions & 0 deletions test/file-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict';

const expect = require('chai').expect;
const fileReader = require('../lib/file-reader.js');

describe('File reading module', function() {
describe('with improper paths', function() {
it('should return with an error', function() {
fileReader(`${__dirname}/dont-exit.text`, function() {
expect(err).to.equal(true);
});
});
});
describe('with a proper paths', function() {
before((done) => {
this.paths = [
`${__dirname}/../data/one.txt`,
`${__dirname}/../data/two.txt`,
`${__dirname}/../data/three.txt`,
];
});
it('should have the correct order of hex strings read in', (done) => {
var expectedResult = [];
readFile(this.paths, function(err, data) {
expect(err).to.equal(null);
expect(data[0]).to.equal(expectedResult[0]);
expect(data[1]).to.equal(expectedResult[1]);
expect(data[2]).to.equal(expectedResult[2]);
console.log('data', data);
done();
});
});
});
});