Lab3 corrections made #17

jtwalters25 · 2017-02-20T02:49:43Z

No description provided.

jalleng · 2017-02-20T16:41:57Z

index.js

+'use strict';
+
+const fileReader = require('./lib/file-reader.js');
+


Hey Jeremiah. Is this file 'file-reader.js' in your repo? I am not seeing it and It is throwing an error in my console.

jalleng · 2017-02-20T22:48:29Z

lib/read-file.js

+
+const readFileHelper = module.exports = function(pathArray, callback) {
+  var result = [];
+


I like that you are passing in the file paths as an array.

jalleng · 2017-02-20T22:49:07Z

lib/read-file.js

+  var result = [];
+
+  fs.readFile(pathArray[0], function(err, data) {
+    if (err) return callback(err);


Good Job returning the error with the callback.

jalleng · 2017-02-20T22:51:33Z

test/file-reader-test.js

+        expect(data[2]).to.equal(expectedResult[2]);
+        console.log('data', data);
+        done();
+      });


This is a good test. It will make sure that your files are coming back in the correct order.

jtwalters25 added 2 commits February 16, 2017 10:11

lab3

e1238f9

corrected index.js

7e661bb

jalleng reviewed Feb 20, 2017

View reviewed changes

resubmit

8740877

jalleng reviewed Feb 20, 2017

View reviewed changes

Provide feedback

		'use strict';

		const fileReader = require('./lib/file-reader.js');


		const readFileHelper = module.exports = function(pathArray, callback) {
		var result = [];