Yana - revisions #18
Open
Yana - revisions #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalleng
reviewed
Feb 20, 2017
| }); | ||
|
|
||
| gulp.task('lint', function() { | ||
| return gulp.src(['./**/*.js', '!node_modules/**']).pipe(eslint()).pipe(eslint.format()).pipe(eslint.failAfterError()); |
There was a problem hiding this comment.
This might be more readable if you drop each .pipe onto the next line.
jalleng
reviewed
Feb 20, 2017
|
|
||
| const reader = require(`${__dirname}/lib/read-files.js`); | ||
|
|
||
| reader.fetchFiles(reader.files, reader.readFiles, reader.logThem); |
There was a problem hiding this comment.
Good Job making this callable from index.js.
jalleng
reviewed
Feb 20, 2017
| const fs = require('fs'); | ||
| module.exports = exports = {}; | ||
| exports.files = [`${__dirname}/../data/one.txt`, `${__dirname}/../data/two.txt`, `${__dirname}/../data/three.txt`]; | ||
|
|
There was a problem hiding this comment.
I like that you put your file paths in an array.
jalleng
reviewed
Feb 20, 2017
| expect(data[1]).to.include('two'); | ||
| expect(data[2]).to.include('three'); | ||
| done(); | ||
| }); |
There was a problem hiding this comment.
Good job verifying the order of your file reads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.