-
Notifications
You must be signed in to change notification settings - Fork 15
Tests pass! #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
npisciotti1
wants to merge
4
commits into
codefellows-javascript-401d13:master
Choose a base branch
from
npisciotti1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tests pass! #2
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b42f08b
created basic files and installed necessary dependencies
sneakyneeks2 f83d5e7
got all files to read, they are outputting in order, however not sure…
sneakyneeks2 5e22c7f
wrote meaningful (ideally) tests, they are passing and results are pr…
sneakyneeks2 9dca695
refactored code similar to how we completed in class with lexical arr…
sneakyneeks2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
# Created by https://www.gitignore.io/api/node,osx,windows,linux | ||
|
||
### Linux ### | ||
*~ | ||
|
||
# temporary files which can be created if a process still has a handle open of a deleted file | ||
.fuse_hidden* | ||
|
||
# KDE directory preferences | ||
.directory | ||
|
||
# Linux trash folder which might appear on any partition or disk | ||
.Trash-* | ||
|
||
# .nfs files are created when an open file is removed but is still being accessed | ||
.nfs* | ||
|
||
### Node ### | ||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
|
||
# Runtime data | ||
pids | ||
*.pid | ||
*.seed | ||
*.pid.lock | ||
|
||
# Directory for instrumented libs generated by jscoverage/JSCover | ||
lib-cov | ||
|
||
# Coverage directory used by tools like istanbul | ||
coverage | ||
|
||
# nyc test coverage | ||
.nyc_output | ||
|
||
# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) | ||
.grunt | ||
|
||
# Bower dependency directory (https://bower.io/) | ||
bower_components | ||
|
||
# node-waf configuration | ||
.lock-wscript | ||
|
||
# Compiled binary addons (http://nodejs.org/api/addons.html) | ||
build/Release | ||
|
||
# Dependency directories | ||
node_modules/ | ||
jspm_packages/ | ||
|
||
# Typescript v1 declaration files | ||
typings/ | ||
|
||
# Optional npm cache directory | ||
.npm | ||
|
||
# Optional eslint cache | ||
.eslintcache | ||
|
||
# Optional REPL history | ||
.node_repl_history | ||
|
||
# Output of 'npm pack' | ||
*.tgz | ||
|
||
# Yarn Integrity file | ||
.yarn-integrity | ||
|
||
# dotenv environment variables file | ||
.env | ||
|
||
|
||
### OSX ### | ||
*.DS_Store | ||
.AppleDouble | ||
.LSOverride | ||
|
||
# Icon must end with two \r | ||
Icon | ||
|
||
|
||
# Thumbnails | ||
._* | ||
|
||
# Files that might appear in the root of a volume | ||
.DocumentRevisions-V100 | ||
.fseventsd | ||
.Spotlight-V100 | ||
.TemporaryItems | ||
.Trashes | ||
.VolumeIcon.icns | ||
.com.apple.timemachine.donotpresent | ||
|
||
# Directories potentially created on remote AFP share | ||
.AppleDB | ||
.AppleDesktop | ||
Network Trash Folder | ||
Temporary Items | ||
.apdisk | ||
|
||
### Windows ### | ||
# Windows thumbnail cache files | ||
Thumbs.db | ||
ehthumbs.db | ||
ehthumbs_vista.db | ||
|
||
# Folder config file | ||
Desktop.ini | ||
|
||
# Recycle Bin used on file shares | ||
$RECYCLE.BIN/ | ||
|
||
# Windows Installer files | ||
*.cab | ||
*.msi | ||
*.msm | ||
*.msp | ||
|
||
# Windows shortcuts | ||
*.lnk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This is a great thing to talk about because I have nothing else to say |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
lah dee friggen dah, har dee harr harr. Boop da woop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
'use-strict'; | ||
|
||
const fileReader = require('./lib/file-reader.js'); | ||
|
||
fileReader.readAllFiles(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
'use-strict'; | ||
|
||
const fs = require('fs'); | ||
|
||
module.exports = exports = {}; | ||
|
||
exports.readSingleFile = function(file, callback) { | ||
fs.readFile(file, function(err, data) { | ||
if(err) return callback(err); | ||
var buffer = new Buffer(data); | ||
var hexData = buffer.toString('hex', 0, 8); | ||
|
||
return callback(null, hexData); | ||
}); | ||
}; | ||
|
||
var paths = [ | ||
`${__dirname}/../data/one.txt`, | ||
`${__dirname}/../data/two.txt`, | ||
`${__dirname}/../data/three.txt` | ||
]; | ||
|
||
exports.readAllFiles = function(pathArray, callback) { | ||
var results = []; | ||
fs.readFile(pathArray[0], function(err, data){ | ||
if(err) return callback(err); | ||
results.push(data.toString('hex', 0, 8)); | ||
|
||
fs.readFile(pathArray[1], function(err, data){ | ||
if(err) return callback(err); | ||
results.push(data.toString('hex', 0, 8)); | ||
|
||
fs.readFile(pathArray[2], function(err, data){ | ||
if(err) return callback(err); | ||
results.push(data.toString('hex', 0, 8)); | ||
callback(null, results); | ||
}); | ||
}); | ||
}); | ||
}; | ||
|
||
// exports.readAllFiles(paths, function(err, data){ | ||
// console.log('data', data); | ||
// }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"name": "03-parallel_file_processing", | ||
"version": "1.0.0", | ||
"description": " Lab 03: Parallel File Processing ===", | ||
"main": "index.js", | ||
"directories": { | ||
"test": "test" | ||
}, | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/npisciotti1/03-parallel_file_processing.git" | ||
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC", | ||
"bugs": { | ||
"url": "https://github.com/npisciotti1/03-parallel_file_processing/issues" | ||
}, | ||
"homepage": "https://github.com/npisciotti1/03-parallel_file_processing#readme", | ||
"devDependencies": { | ||
"chai": "^3.5.0", | ||
"mocha": "^3.2.0", | ||
"mocha-test": "^2.0.3" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
'use-strict'; | ||
|
||
const expect = require('chai').expect; | ||
const fileReader = require('../lib/file-reader.js'); | ||
|
||
|
||
|
||
|
||
|
||
describe('File Reader', function() { | ||
describe('Hex values should display in order.', function() { | ||
before((done) => { | ||
this.paths = [ | ||
`${__dirname}/../data/one.txt`, | ||
`${__dirname}/../data/two.txt`, | ||
`${__dirname}/../data/three.txt` | ||
]; | ||
done(); | ||
}); | ||
it('should test pathArray and correctly log each result', (done) => { | ||
var expectedResults = ['5468697320697320', '6c61682064656520', '4c6f72656d206970']; | ||
fileReader.readAllFiles(this.paths, function(err, data) { | ||
expect(err).to.equal(null); | ||
expect(data[0]).to.equal(expectedResults[0]); | ||
expect(data[1]).to.equal(expectedResults[1]); | ||
expect(data[2]).to.equal(expectedResults[2]); | ||
console.log('data', data); | ||
done(); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good job remembering to call done(). Also, this is a good test it will make sure everything is coming back in order. |
||
}); | ||
}); | ||
describe('An incorrect file-path should fail', function() { | ||
it('should throw an error', function(done) { | ||
fileReader.readSingleFile(`${__dirname}/../data/bullshit.txt`, function(err, data) { | ||
expect(err).to.be.an('error'); | ||
done(); | ||
}); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You set up your function to take an array of file names and a callback but you aren't passing in any parameters here when you call it. Refactor index.js slightly so that you can call node index.js from the command line and have it print out the data you are looking for. You are really close here!