-
Notifications
You must be signed in to change notification settings - Fork 15
completed #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
completed #20
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
"rules": { | ||
"no-console": "off", | ||
"indent": [ "error", 2 ], | ||
"quotes": [ "error", "single" ], | ||
"semi": ["error", "always"], | ||
"linebreak-style": [ "error", "unix" ] | ||
}, | ||
"env": { | ||
"es6": true, | ||
"node": true, | ||
"mocha": true, | ||
"jasmine": true | ||
}, | ||
"ecmaFeatures": { | ||
"modules": true, | ||
"experimentalObjectRestSpread": true, | ||
"impliedStrict": true | ||
}, | ||
"extends": "eslint:recommended" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
# Created by https://www.gitignore.io/api/node,vim,osx,macos,linux | ||
|
||
*node_modules | ||
|
||
### Node ### | ||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
|
||
# Runtime data | ||
pids | ||
*.pid | ||
*.seed | ||
*.pid.lock | ||
|
||
# Directory for instrumented libs generated by jscoverage/JSCover | ||
lib-cov | ||
|
||
# Coverage directory used by tools like istanbul | ||
coverage | ||
|
||
# nyc test coverage | ||
.nyc_output | ||
|
||
# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) | ||
.grunt | ||
|
||
# node-waf configuration | ||
.lock-wscript | ||
|
||
# Compiled binary addons (http://nodejs.org/api/addons.html) | ||
build/Release | ||
|
||
# Dependency directories | ||
node_modules | ||
jspm_packages | ||
|
||
# Optional npm cache directory | ||
.npm | ||
|
||
# Optional eslint cache | ||
.eslintcache | ||
|
||
# Optional REPL history | ||
.node_repl_history | ||
|
||
# Output of 'npm pack' | ||
*.tgz | ||
|
||
# Yarn Integrity file | ||
.yarn-integrity | ||
|
||
|
||
|
||
### Vim ### | ||
# swap | ||
[._]*.s[a-v][a-z] | ||
[._]*.sw[a-p] | ||
[._]s[a-v][a-z] | ||
[._]sw[a-p] | ||
# session | ||
Session.vim | ||
# temporary | ||
.netrwhist | ||
*~ | ||
# auto-generated tag files | ||
tags | ||
|
||
|
||
### OSX ### | ||
*.DS_Store | ||
.AppleDouble | ||
.LSOverride | ||
|
||
# Icon must end with two \r | ||
Icon | ||
# Thumbnails | ||
._* | ||
# Files that might appear in the root of a volume | ||
.DocumentRevisions-V100 | ||
.fseventsd | ||
.Spotlight-V100 | ||
.TemporaryItems | ||
.Trashes | ||
.VolumeIcon.icns | ||
.com.apple.timemachine.donotpresent | ||
# Directories potentially created on remote AFP share | ||
.AppleDB | ||
.AppleDesktop | ||
Network Trash Folder | ||
Temporary Items | ||
.apdisk | ||
|
||
|
||
### macOS ### | ||
# Icon must end with two \r | ||
# Thumbnails | ||
# Files that might appear in the root of a volume | ||
# Directories potentially created on remote AFP share | ||
|
||
|
||
### Linux ### | ||
|
||
# temporary files which can be created if a process still has a handle open of a deleted file | ||
.fuse_hidden* | ||
|
||
# KDE directory preferences | ||
.directory | ||
|
||
# Linux trash folder which might appear on any partition or disk | ||
.Trash-* | ||
|
||
# .nfs files are created when an open file is removed but is still being accessed | ||
.nfs* | ||
|
||
# End of https://www.gitignore.io/api/node,vim,osx,macos,linux | ||
l |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Hello this is test one |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Hello this is test three |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Hello this is test two | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
'use strict'; | ||
|
||
const gulp = require('gulp'); | ||
const eslint = require('gulp-eslint'); | ||
const mocha = require('gulp-mocha'); | ||
|
||
gulp.task('test', function() { | ||
gulp.src('./test/*-test.js', { | ||
read: false | ||
}) | ||
.pipe(mocha({ | ||
reporter: 'spec' | ||
})); | ||
}); | ||
|
||
gulp.task('lint', function() { | ||
return gulp.src(['**/*.js', '!node_modules']) | ||
.pipe(eslint()) | ||
.pipe(eslint.format()) | ||
.pipe(eslint.failAfterError()); | ||
}); | ||
|
||
gulp.task('dev', function() { | ||
gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']); | ||
}); | ||
|
||
gulp.task('default', ['dev']); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'use strict'; | ||
|
||
const fs = require('fs'); | ||
|
||
const fileReader = require('./lib/file-reader.js') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good job requiring in your function. |
||
|
||
fileReader(`${__dirname}/./data/one.txt`, function(err, data) { | ||
if (err) throw err; | ||
console.log('one:', data.toString('hex', 0, 8)); | ||
}); | ||
|
||
fileReader(`${__dirname}/./data/two.txt`, function(err, data) { | ||
if (err) throw err; | ||
console.log('two:', data.toString('hex', 0, 8)); | ||
}); | ||
|
||
fileReader(`${__dirname}/./data/two.txt`, function(err, data) { | ||
if (err) throw err; | ||
console.log('three:', data.toString('hex', 0, 8)); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should have one function that reads all three files 'in order'. Not a function that reads one file that you call three times. There is also no way with the way you are doing it here to guarantee that they come back in order. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
'use strict'; | ||
|
||
const fs = require('fs'); | ||
|
||
const fileReader = module.exports = function(file, callback){ | ||
fs.readFile(file, function(err, data){ | ||
if (err) callback(err); | ||
return callback(null, data.toString('hex',0,8)); | ||
}); | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are using the readFile function correctly to read a file. But you need to be reading all three files in order. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{ | ||
"name": "03-parallel_file_processing", | ||
"version": "1.0.0", | ||
"description": " Lab 03: Parallel File Processing ===", | ||
"main": "index.js", | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/sueanyv/03-parallel_file_processing.git" | ||
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC", | ||
"bugs": { | ||
"url": "https://github.com/sueanyv/03-parallel_file_processing/issues" | ||
}, | ||
"homepage": "https://github.com/sueanyv/03-parallel_file_processing#readme", | ||
"devDependencies": { | ||
"chai": "^3.5.0", | ||
"gulp": "^3.9.1", | ||
"gulp-eslint": "^3.0.1", | ||
"mocha": "^3.2.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
'use strict'; | ||
|
||
const fs = require('fs'); | ||
const expect = require('chai').expect; | ||
const fileReader = require('../lib/file-reader.js'); | ||
|
||
describe('Reading all three files', function(){ | ||
|
||
|
||
it('should rad the files in order, and provide the first 8 bytes of each file', function(done){ | ||
fileReader(`${__dirname}/../data/one.txt`, function(err, data){ | ||
expect(err).to.equal(err); | ||
expect(data).to.equal('48656c6c6f207468'); | ||
expect(data).to.have.length.above(8); | ||
fileReader(`${__dirname}/../data/two.txt`, function(err, data){ | ||
expect(err).to.equal(err); | ||
expect(data).to.equal('48656c6c6f207468'); | ||
expect(data).to.have.length.above(8); | ||
fileReader(`${__dirname}/../data/three.txt`, function(err, data){ | ||
expect(err).to.equal(err); | ||
expect(data).to.equal('48656c6c6f207468'); | ||
expect(data).to.have.length.above(8); | ||
done(); | ||
}); | ||
}); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The way you set up your test here is similar to the way that you should set up your function in the file-reader.js file. |
||
}); | ||
it('File not found.', function(done) { | ||
fileReader('', function(err, data) { | ||
expect(err).to.exist; | ||
expect(data).to.not.exist; | ||
done(); | ||
}); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should make your sample test different for each file. You are only reading the beginning of each string and they all start the same here. So you won't know which order they are coming out.