Skip to content

Test fixed #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
"linebreak-style": [ "error", "unix" ]
},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
118 changes: 118 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
# Created by https://www.gitignore.io/api/node,vim,osx,macos,linux

*node_modules

### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity



### Vim ###
# swap
[._]*.s[a-v][a-z]
[._]*.sw[a-p]
[._]s[a-v][a-z]
[._]sw[a-p]
# session
Session.vim
# temporary
.netrwhist
*~
# auto-generated tag files
tags


### OSX ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon
# Thumbnails
._*
# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent
# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk


### macOS ###
# Icon must end with two \r
# Thumbnails
# Files that might appear in the root of a volume
# Directories potentially created on remote AFP share


### Linux ###

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

# End of https://www.gitignore.io/api/node,vim,osx,macos,linux
l
1 change: 1 addition & 0 deletions data/one.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello this is test one
1 change: 1 addition & 0 deletions data/three.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello this is test thre
1 change: 1 addition & 0 deletions data/two.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello this is test two
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first 8 bytes of your test files are all the same. Each one needs to be different in order for you to tell if they are logging out in the order that you are looking for.

27 changes: 27 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';

const gulp = require('gulp');
const eslint = require('gulp-eslint');
const mocha = require('gulp-mocha');
Copy link

@jalleng jalleng Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are requiring gulp-mocha here but it is not in your package.json. Make sure that you save it as a devDependency.


gulp.task('test', function() {
gulp.src('./test/*-test.js', {
read: false
})
.pipe(mocha({
reporter: 'spec'
}));
});

gulp.task('lint', function() {
return gulp.src(['**/*.js', '!node_modules'])
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

gulp.task('dev', function() {
gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']);
});

gulp.task('default', ['dev']);
20 changes: 20 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict';

const fs = require('fs');

const fileReader = require('./lib/file-reader.js')

fileReader(`${__dirname}/./data/one.txt`, function(err, data) {
if (err) throw err;
console.log('one:', data.toString('hex', 0, 8));
});

fileReader(`${__dirname}/./data/two.txt`, function(err, data) {
if (err) throw err;
console.log('two:', data.toString('hex', 0, 8));
});

fileReader(`${__dirname}/./data/two.txt`, function(err, data) {
if (err) throw err;
console.log('three:', data.toString('hex', 0, 8));
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your index should just call the function that you set up in file-reader.js one time and hand it a callback. So you can run 'node index.js in the terminal and see it output the three files in order.

24 changes: 24 additions & 0 deletions lib/file-reader.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict';

const fs = require('fs');

const fileReader = module.exports = function(pathArray, callback) {

var dataNum = [];

fs.readFile(pathArray[0], function(err, data) {
if (err) callback(err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job calling the callback with the err.

dataNum.push(data.toString('hex', 0, 8));
fs.readFile(pathArray[1], function(err, data) {
if (err) callback(err);
dataNum.push(data.toString('hex', 0, 8));
fs.readFile(pathArray[2], function(err, data) {
if (err) callback(err);
dataNum.push(data.toString('hex', 0, 8));
console.log(dataNum);
callback(null, dataNum);

});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this. I like that your function takes an array of file names as a parameter.

});
});
};
26 changes: 26 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"name": "03-parallel_file_processing",
"version": "1.0.0",
"description": "![CF](https://camo.githubusercontent.com/70edab54bba80edb7493cad3135e9606781cbb6b/687474703a2f2f692e696d6775722e636f6d2f377635415363382e706e67) Lab 03: Parallel File Processing ===",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"repository": {
"type": "git",
"url": "git+https://github.com/sueanyv/03-parallel_file_processing.git"
},
"keywords": [],
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/sueanyv/03-parallel_file_processing/issues"
},
"homepage": "https://github.com/sueanyv/03-parallel_file_processing#readme",
"devDependencies": {
"chai": "^3.5.0",
"gulp": "^3.9.1",
"gulp-eslint": "^3.0.1",
"mocha": "^3.2.0"
}
}
34 changes: 34 additions & 0 deletions test/file-reader-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict';

const expect = require('chai').expect;
const readFile = require('../lib/file-reader.js');

describe('Read File Helper Module', () =>{
describe('with bad file paths', () =>{
it('should return an error', () =>{
readFile([`${__dirname}/.txt`], (err) =>{
});
});
});
describe('with good file paths', () =>{
before((done) => {
this.paths = [
`${__dirname}/../data/one.txt`,
`${__dirname}/../data/two.txt`,
`${__dirname}/../data/three.txt`
];
done();
});
it('should have correct order of hex strings', (done) => {
var dataNum = ['48656c6c6f207468', '48656c6c6f207468', '48656c6c6f207468'];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all the same. How can you tell what order they are coming back in?

readFile(this.paths, (err, data) =>{
expect(err).to.equal(null);
expect(data[0]).to.equal(dataNum[0]);
expect(data[1]).to.equal(dataNum[1]);
expect(data[2]).to.equal(dataNum[2]);
console.log('data', data);
done();
});
});
});
});