Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests time out #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lab-anna/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@

{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
"linebreak-style": [ "error", "unix" ]
},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
117 changes: 117 additions & 0 deletions lab-anna/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
# Created by https://www.gitignore.io/api/node,vim,osx,macos,linux

*node_modules

### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity



### Vim ###
# swap
[._]*.s[a-v][a-z]
[._]*.sw[a-p]
[._]s[a-v][a-z]
[._]sw[a-p]
# session
Session.vim
# temporary
.netrwhist
*~
# auto-generated tag files
tags


### OSX ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon
# Thumbnails
._*
# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent
# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk


### macOS ###
# Icon must end with two \r
# Thumbnails
# Files that might appear in the root of a volume
# Directories potentially created on remote AFP share


### Linux ###

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

# End of https://www.gitignore.io/api/node,vim,osx,macos,linux
1 change: 1 addition & 0 deletions lab-anna/data/one.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Same an quit most an. Admitting an mr disposing sportsmen. Tried on cause no spoil arise plate. Longer ladies valley get esteem use led six. Middletons resolution advantages expression themselves partiality so me at. West none hope if sing oh sent tell is.
1 change: 1 addition & 0 deletions lab-anna/data/three.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Unwilling sportsmen he in questions september therefore described so. Attacks may set few believe moments was. Reasonably how possession shy way introduced age inquietude. Missed he engage no exeter of. Still tried means we aware order among on. Eldest father can design tastes did joy settle. Roused future he ye an marked. Arose mr rapid in so vexed words. Gay welcome led add lasting chiefly say looking.
1 change: 1 addition & 0 deletions lab-anna/data/two.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do greatest at in learning steepest. Breakfast extremity suffering one who all otherwise suspected. He at no nothing forbade up moments. Wholly uneasy at missed be of pretty whence. John way sir high than law who week. Surrounded prosperous introduced it if is up dispatched. Improved so strictly produced answered elegance is.
23 changes: 23 additions & 0 deletions lab-anna/gulpfile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'use strict';

const gulp = require('gulp');
const eslint = require('gulp-eslint');
const mocha = require('gulp-mocha');

gulp.task('test', function() {
gulp.src('./test/*-test.js', {read: false})
.pipe(mocha({reporter: 'spec'}));
});

gulp.task('lint', function() {
return gulp.src(['**/*.js', '!node_modules'])
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

gulp.task('dev', function() {
gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']);
});

gulp.task('default', ['dev']);
5 changes: 5 additions & 0 deletions lab-anna/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

const files = require('./lib/read.js');

files.printOut();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job requiring your function in here. But you aren't quite calling it correctly. files.printOut is not a function. How can you refactor index.js so that it is calling your function correctly?

34 changes: 34 additions & 0 deletions lab-anna/lib/read.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
const fs = require('fs');

// module.exports = exports = {};


const printOut = module.exports = function(textFiles, callback) {
// const textFiles = [`${__dirname}/../data/one.txt`, `${__dirname}/../data/two.txt`, `${__dirname}/../data/three.txt`];

var f1 = '';
var f2 = '';
var f3 = '';

var logArray = [];
fs.readFile(textFiles[0], function(err, data) {
if (err) return callback(err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job returning your callback with the err.

f1 = data.slice(0, 8).toString()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the assignment asks for the first 8bits in 'HEX'.

logArray.push(f1);
console.log(f1);
fs.readFile(textFiles[1], function(err, data) {
if (err) return callback(err);
f2 = data.slice(0, 8).toString()
logArray.push(f2);
console.log(f2);
fs.readFile(textFiles[2], function(err, data) {
if (err) return callback(err);
f3 = data.slice(0, 8).toString()
logArray.push(f3);
console.log(f3);
return callback(null, logArray);
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job pushing your values into an array and returning the array with the callback.

});
});

};
19 changes: 19 additions & 0 deletions lab-anna/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"name": "lab-anna",
"version": "1.0.0",
"description": "",
"main": "index.js",
"directories": {
"test": "test"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"chai": "^3.5.0",
"mocha": "^3.2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add gulp-mocha and gulp-eslint as devDependencies.

}
}
52 changes: 52 additions & 0 deletions lab-anna/test/read-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
'use strict';

const expect = require('chai').expect;
const reader = require('../lib/read.js');

const textFiles = [`${__dirname}/../data/one.txt`, `${__dirname}/../data/two.txt`, `${__dirname}/../data/three.txt`];


describe('Read Module', function() {
describe('with an improper file path', function() {
it('should return an error', function(done) {
reader([`${__dirname}/../data/noone.txt`, `${__dirname}/../data/two.txt`, `${__dirname}/../data/three.txt`], function(err) {
expect(err).to.be.an('error');
done();
});
});
});

describe('with a proper file path', function() {
it('should return the contents of the file', function(done) {
reader(textFiles, function(err, data) {
expect(err).to.equal(null);
expect(data[0]).to.be.a('string');
expect(data[0]).to.equal('Same an ');
done();
});
});

});
describe('with a proper file path', function() {
it('should return the contents of the file', function(done) {
reader(textFiles, function(err, data) {
expect(err).to.equal(null);
expect(data[1]).to.be.a('string');
expect(data[1]).to.equal('Do great');
done();
});
});
});

describe('with a proper file path', function() {
it('should return the contents of the file', function(done) {
reader(textFiles, function(err, data) {
expect(err).to.equal(null);
expect(data[2]).to.be.a('string');
expect(data[2]).to.equal('Unwillin');
done();
});
});

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job checking that the files are returned in the correct order. You could refactor this slightly though so that it is only calling the function one time. Then just add the rest of the expect statements into the same test. Kind of like this:
expect(data[0]).to.equal('Same an ');
expect(data[1]).to.equal('Do great'):
expect(data[2]).to.equal('Unwillin'):

});
});