Skip to content

Zachary Crumbo Assignment 3 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
"linebreak-style": [ "error", "unix" ]
},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
129 changes: 129 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@

# Created by https://www.gitignore.io/api/node,osx,windows,linux

### Linux ###
*~

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

### Node ###
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Typescript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env


### OSX ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon


# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk

### Windows ###
# Windows thumbnail cache files
Thumbs.db
ehthumbs.db
ehthumbs_vista.db

# Folder config file
Desktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msm
*.msp

# Windows shortcuts
*.lnk

# End of https://www.gitignore.io/api/node,osx,windows,linux
1 change: 1 addition & 0 deletions data/one.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1 this is the contents of text
1 change: 1 addition & 0 deletions data/three.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
this is the contents of text 3
1 change: 1 addition & 0 deletions data/two.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2 contents are right here
23 changes: 23 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'use strict';

const gulp=require('gulp');
const eslint = require('gulp-eslint');
const mocha = require('gulp-mocha');

gulp.task('test', function(){
gulp.src('*/*-test.js', {read:false})
.pipe(mocha({reporter: 'spec'}));
});

gulp.task('lint', function(){
return gulp.src(['**/*.js', '!node_modules'])
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

gulp.task('dev', function(){
gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']);
});

gulp.task('default', ['dev']);
16 changes: 16 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';

const fileReader = require('./lib/read-file.js');

fileReader('one.txt', 'two.txt', 'three.txt', waitForIt);

function waitForIt(err, data){
if(err) throw err;
data.forEach(logArrayElements);
function logArrayElements(element, i) {
console.log(`file ${i} ${element}`);
}
}



27 changes: 27 additions & 0 deletions lib/read-file.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';

const fs = require('fs');
const resultsArray = [];



module.exports = function(file1, file2, file3, callback){

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is set up well. I like that you are passing in your file names as parameters.

fs.readFile(`${__dirname}/../data/${file1}`, function(err,data){
if (err) return callback(err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job returning your error with the callback.


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need this white space here.

var first = data.toString('hex').substring(0,8);
resultsArray.push(first);
fs.readFile(`${__dirname}/../data/${file2}`, function(err,data){
if (err) return callback(err);
var second = data.toString('hex').substring(0,8);
resultsArray.push(second);
fs.readFile(`${__dirname}/../data/${file3}`, function(err,data){
if (err) return callback(err);
var third = data.toString('hex').substring(0,8);
resultsArray.push(third);
return callback(null, resultsArray);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job pushing your data into an array and passing back the array at the end. This takes care of the asynchronous nature of the file reads.

});
});
});
};
33 changes: 33 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
{
"name": "03-parallel_file_processing",
"version": "1.0.0",
"description": "![CF](https://camo.githubusercontent.com/70edab54bba80edb7493cad3135e9606781cbb6b/687474703a2f2f692e696d6775722e636f6d2f377635415363382e706e67) Lab 03: Parallel File Processing ===",
"main": "index.js",
"directories": {
"test": "test"
},
"dependencies": {
"chai": "^3.5.0",
"gulp-cli": "^1.2.2",
"gulp": "^3.9.1",
"gulp-eslint": "^3.0.1",
"gulp-mocha": "^3.0.1"
},
"devDependencies": {
"mocha": "^3.2.0"
},
"scripts": {
"test": "mocha"
},
"repository": {
"type": "git",
"url": "git+https://github.com/zcrumbo/03-parallel_file_processing.git"
},
"keywords": [],
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/zcrumbo/03-parallel_file_processing/issues"
},
"homepage": "https://github.com/zcrumbo/03-parallel_file_processing#readme"
}
29 changes: 29 additions & 0 deletions test/fs-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
'use strict';

const expect = require('chai').expect;
const fileReader = require('../lib/read-file.js');

describe('FS Module', function(){
describe('with an improper file path', function(){
it('should return file path error', function(done){
fileReader('fake.txt', 'file.txt', 'paths.txt', function(err){
expect(err).to.be.an('error');
done();
});
});
});
describe('with an out of order data return', function(){
it('should flag it as out of order', function(done){
fileReader('one.txt', 'two.txt', 'three.txt', dataReturn);
function dataReturn(err ,data){
var testData = new Array('31207468', '3220636f', '74686973');
expect(data[0]).to.equal(testData[0]);
expect(data[1]).to.equal(testData[1]);
expect(data[2]).to.equal(testData[2]);
done();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here. This verify's that they are in the correct order.

}
});
});
});