lab-remil #6
Open
lab-remil #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broxsonl
reviewed
Feb 16, 2017
| "quotes": [ "error", "single" ], | ||
| "semi": ["error", "always"], | ||
| "linebreak-style": [ "error", "windows" ], | ||
| "comma-dangle": ["error", "always-multiline"] |
| @@ -0,0 +1,117 @@ | |||
| # Created by https://www.gitignore.io/api/node,vim,osx,macos,linux | |||
|
|
|||
| *node_modules | |||
| @@ -0,0 +1 @@ | |||
| All hail the redskins!!! | |||
| @@ -0,0 +1 @@ | |||
| The doppity doppest doptacular dopeness eva | |||
| gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']); | ||
| }); | ||
|
|
||
| gulp.task('default', ['dev']); |
There was a problem hiding this comment.
Nice work setting your default gulp task to run all of your other gulp tasks.
| return bufferObj.toString('hex', 0, 8); | ||
| }; | ||
|
|
||
| for(let i=0; i < files.length; i++) { |
There was a problem hiding this comment.
Typically you want a space around the = in your first for loop argument.
e.g. i = 0 is cleaner and a bit more "conventional".
| if (resultArray.filter(function(file){ | ||
| return Object.keys(file).includes('result'); | ||
| }).length === files.length) { | ||
| return callback(null, resultArray); |
| describe('FileLogger Module', function() { | ||
| describe('with an improper file path', function(){ | ||
| it('should return an error', function(done) { | ||
| let badFilePath = 'badfile/sobad'; |
| fileLogger(input , function(err, data) { | ||
| expect(err).to.equal(null); | ||
| expect(data).to.be.an('array'); | ||
| expect(data.length).to.equal(input.length); |
There was a problem hiding this comment.
Cool. Yup, our output array's length should be the same. Good length.
| }); | ||
| }); | ||
| }); | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] For this assignment you will need to read three files and console log the first 8 bytes (in hex) of each file.
[x] Regardless of file size, all three files should be read and logged in the order 'one.txt', 'two.txt', 'three.txt'.
[x] You will need to include tests that guarantee that the files are logged in the proper order.
[x] You will also need to include tests that check for improper file paths.