Skip to content

completed day 3 lab #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
"linebreak-style": [ "error", "unix" ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comma dangle. :p Boo

},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
117 changes: 117 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
# Created by https://www.gitignore.io/api/node,vim,osx,macos,linux

*node_modules

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ignoring node modules


### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity



### Vim ###
# swap
[._]*.s[a-v][a-z]
[._]*.sw[a-p]
[._]s[a-v][a-z]
[._]sw[a-p]
# session
Session.vim
# temporary
.netrwhist
*~
# auto-generated tag files
tags


### OSX ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon
# Thumbnails
._*
# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent
# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk


### macOS ###
# Icon must end with two \r
# Thumbnails
# Files that might appear in the root of a volume
# Directories potentially created on remote AFP share


### Linux ###

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

# End of https://www.gitignore.io/api/node,vim,osx,macos,linux
1 change: 1 addition & 0 deletions data/one.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Brian is a pretty cool teacher

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure he would appreciate this text file.

1 change: 1 addition & 0 deletions data/three.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hopefully I get this right

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me!

1 change: 1 addition & 0 deletions data/two.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Too bad he makes me text this in order

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, what a jerk. :p

23 changes: 23 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'use strict';

const gulp = require('gulp');
const eslint = require('gulp-eslint');
const mocha = require('gulp-mocha');

gulp.task('test', function(){
gulp.src('./test/*-test.js', {read: false})
.pipe(mocha({reporter:'nyan'}));
});

gulp.task('lint', function(){
return gulp.src(['**/*.js', '!node_modules/**'])
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

gulp.task('dev', function(){
gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']);
});

gulp.task('default', ['dev']);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work having your default task run all of your other tasks!

5 changes: 5 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

const fileReader = require('./lib/file-reader.js');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, semantic name for this module.


fileReader(`${__dirname}/data/one.txt`, `${__dirname}/data/two.txt`, `${__dirname}/data/three.txt`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not calling it here with a callback function included?

38 changes: 38 additions & 0 deletions lib/file-reader.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
'use strict';

const fs = require('fs');

const fileReader = module.exports = function(file1, file2, file3, callback){
let resArr = [];
fs.readFile(file1, function(err, data){
if(err) return callback(err);
var eightHexes = data.toString('hex')
.match(/.{1,2}/g)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice regex. :)

.filter(function(ele, index){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of a higher order array method.

return index <= 7;
}).join('');
resArr.push(eightHexes);
console.log(eightHexes);
fs.readFile(file2, function(err, data){
if(err) return callback(err);
eightHexes = data.toString('hex')
.match(/.{1,2}/g)
.filter(function(ele, index){
return index <= 7;
}).join('');
resArr.push(eightHexes);
console.log(eightHexes);
fs.readFile(file3, function(err, data){
if(err) return callback(err);
eightHexes = data.toString('hex')
.match(/.{1,2}/g)
.filter(function(ele, index){
return index <= 7;
}).join('');
resArr.push(eightHexes);
console.log(eightHexes);
return callback(null, resArr);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the callback here, though I don't see you calling it in your initial function call in your other page?

});
});
});
};
30 changes: 30 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"name": "03-parallel_file_processing",
"version": "1.0.0",
"description": "![CF](https://camo.githubusercontent.com/70edab54bba80edb7493cad3135e9606781cbb6b/687474703a2f2f692e696d6775722e636f6d2f377635415363382e706e67) Lab 03: Parallel File Processing ===",
"main": "index.js",
"directories": {
"test": "test"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"repository": {
"type": "git",
"url": "git+https://github.com/brials/03-parallel_file_processing.git"
},
"keywords": [],
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/brials/03-parallel_file_processing/issues"
},
"homepage": "https://github.com/brials/03-parallel_file_processing#readme",
"devDependencies": {
"chai": "^3.5.0",
"gulp": "^3.9.1",
"gulp-eslint": "^3.0.1",
"gulp-mocha": "^3.0.1",
"mocha": "^3.2.0"
}
}
42 changes: 42 additions & 0 deletions test/file-reader-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
'use strict';

const expect = require('chai').expect;
const fileReader = require('../lib/file-reader.js');

describe('File Reader Module', function(){
describe('with an improper set of filepaths', function(){
it('should return an error', function(done){
fileReader('bad/path1', 'bad/path2', 'bad/path3', function(err){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the bad file paths for the test. The test should fail and throw an error immediately when it hits the first bad file, though.

expect(err).to.be.an('error');
done();
});
});
});
describe('with an improper 2nd & 3rd filepath', function(){
it('should return an error', function(done){
fileReader(`${__dirname}/data/one.txt`, 'bad/path2', 'bad/path3', function(err){
expect(err).to.be.an('error');
done();
});
});
});
describe('with an improper 3rd filepath', function(){
it('should return an error', function(done){
fileReader(`${__dirname}/../data/one.txt`, `${__dirname}/../data/two.txt`, 'bad/path3', function(err){
expect(err).to.be.an('error');
done();
});
});
});
describe('with all of the correct file paths', function(){
it('should return all of the correct data', function(done){
fileReader(`${__dirname}/../data/one.txt`, `${__dirname}/../data/two.txt`, `${__dirname}/../data/three.txt`, function(err, data){
expect(data.length).to.equal(3);
expect(data[0]).to.equal('427269616e206973');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test. Nice work checking the actual returned hex values, as well as the length of the data array being returned.

expect(data[1]).to.equal('546f6f2062616420');
expect(data[2]).to.equal('486f706566756c6c');
done();
});
});
});
});