Gary test template #19
Conversation
worked on the bitmap constructor
Fix read file async
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin - Overall, good job on this assignment. There's a real need for modularity that isn't present at this current iteration but we'll keep talking about it and the creation/exposure of these modules will become second nature soon
| "impliedStrict": true | ||
| }, | ||
| "extends": "eslint:recommended" | ||
| } |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin .eslintrc looks good
| # .nfs files are created when an open file is removed but is still being accessed | ||
| .nfs* | ||
|
|
||
| # End of https://www.gitignore.io/api/node,vim,osx,macos,linux |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin .gitignore looks good
| module.exports = exports = {}; | ||
|
|
||
| exports.readContent = function(callback) { | ||
| fs.readFile(`${__dirname}/../img/palette-bitmap.bmp`, function(err, data) { |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin the function that you use to read a bitmap and subsequently add data as part of the constructor should be extracted out of this readContent method - it's best to create a helper file (ex: bitmap-file-reader) that encapsulates your readFile call and allows you to dynamically pass in a filename for reuse in other modules and for proper testing
| this.imageStart = bitmap.readInt32LE(10); | ||
| this.pixelArray = bitmap.toString('hex', this.imageStart, this.size); | ||
|
|
||
|
|
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin nitpicky time - got some unnecessary whitespace ;)
|
|
||
| }; | ||
| var test = new Image; | ||
| console.log('var test:', test); |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin for future reference, console.log statements should only exist on branches outside of master - master should only contain production code
| var avg = (data[i] + data[i + 1] + data[i + 2]) / 3; | ||
| data[i] = avg; | ||
| data[i + 1] = avg; | ||
| data[i + 2] = avg; |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin grayscale manipulations look good
|
|
||
| exports.readContent.prototype.white = function() { | ||
| this.pixelArray.fill(255); | ||
| }; |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin invert and white transforms look good
|
|
||
| g.readContent(function (err, data) { | ||
|
|
||
| }); |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin any reason this file exists?
| "chai": "^3.5.0", | ||
| "mocha": "^3.2.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin package.json looks as expected
| // read the buffer and compare to our object | ||
| }) | ||
| }) | ||
| }); |
There was a problem hiding this comment.
@GLSea1979 @0blu3 @noahgribbin this needs some actual tests - no worries for now, the overall structure of your describe and it blocks look good - you'll get more comfortable with the actual assertion tests as we continue on in this class
No description provided.