Brian, Cayla, Remi #22
Conversation
color and pixel map
completed constructor and write
pushing some tests up
Transform functions
added tests and refactored code to include callbacks for testing purp…
Graytransform cli
| "impliedStrict": true | ||
| }, | ||
| "extends": "eslint:recommended" | ||
| } |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel .eslintrc looks good
| # .nfs files are created when an open file is removed but is still being accessed | ||
| .nfs* | ||
|
|
||
| # End of https://www.gitignore.io/api/node,vim,osx,macos,linux |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel .gitignore looks good!
|
|
||
| More transformations are to come! | ||
| <br> | ||
| ⒸCodeFellows 2017 Team Bad Hair Day |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel README and associated markdown look good
| return fileColorTransform(files, colorTransforms); | ||
|
|
||
|
|
||
| function fileColorTransform(files, colorTransforms) { |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel might be best to pull this color transformer function out of your transformBMP function for reusability cleanliness and readability
| transformBMP(filesToConvert); | ||
|
|
||
| function transformBMP(files) { | ||
| let colorTransforms = []; |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel good use of an empty array pattern for filling the array in the subsequent for loop
| return [ grayLevel, grayLevel, grayLevel, color[3] ]; | ||
| }; | ||
|
|
||
| Bitmap.colorTransforms = [ 'invertTransform', 'blueTransform', 'grayTransform' ]; |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel transform static methods and related logic look good!
| "gulp-mocha": "^3.0.1", | ||
| "mocha": "^3.2.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel package.json looks as expected and devDependencies houses the appropriate data
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel tests are a bit light but overall test the primary expected results from an instantiated bitmap
| describe('File Reader Module', function(){ | ||
| describe('with an improper file path',function(){ | ||
| it('should return an error', function(done) { | ||
| fileHelper('img/badPath.bmp', 'palette', 'invertTransform', function(err){ |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel as stated in your bitmap-file-helper, excellent pattern of wrapping your file reader so that you can test - great job writing this particular test to check for errors
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@brials @remilonwheels @caylazabel returned bitmap data tests are generally excellent albeit a bit light
No description provided.