lab-dana #11
Open
lab-dana #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in net module and confirmed server starting up.
… if no command given.
…converted all functions to arrow.
| const command = data.toString().split(' ').shift().trim(); | ||
| const msg = data.toString().split(' ').slice(1).join(' '); | ||
|
|
||
| if(command.includes('@all')) { |
There was a problem hiding this comment.
you have a lot of repeated code here. You could probably D.R.Y. this out and use just one conditional.
if(command.startsWith('@')) {
ee.emit(command, client, data.toString().split(' ').slice(1).join(' '));
return;
}JavaScript allows this, you can pass any arbitrary number of arguments to a function so you don't necessarily need to create a different conditional statement to handle each command.
| ///+++++ server events +++++\\\ | ||
|
|
||
| server.on('connection', (socket) => { | ||
| ee.emit('login', socket); |
There was a problem hiding this comment.
This is an awesome way of handling the connection. I like how you modularized your code here and separated out your server events into additional code blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.