lab6-Jeremiah #14
Open
lab6-Jeremiah #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalleng
reviewed
Feb 22, 2017
|
|
||
|
|
||
| socket.on('error', function(err){ | ||
|
|
There was a problem hiding this comment.
You're not handling your error event here. Something should go inside of this function.
jalleng
reviewed
Feb 22, 2017
README.md
Outdated
| ### Chat Features | ||
|
|
||
| * @all triggers a broadcast event | ||
| * @nickname allows a user change their nickname |
jalleng
reviewed
Feb 22, 2017
server.js
Outdated
| return; | ||
| } | ||
|
|
||
| socket.destroy(error); |
There was a problem hiding this comment.
This line is causing your socket to close when a user enters a command that does not satisfy the condition of any of your if blocks. Instead you should continuing down to the default emitter on line 77. You should remove this line from here. You could put it in its own event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.