Brian-lab #13
Brian-lab #13
Conversation
model/rwby.js
Outdated
| let rwby = new Rwby(_rwby.name, _rwby.weapon, _rwby.symbol); | ||
| return storage.createItem('rwby', rwby); | ||
| } catch (err) { | ||
| return Promise.reject(err); |
There was a problem hiding this comment.
Please have more detailed errors using createError like such:
catch (err) {
return Promise.reject(createError(400, err.message));
This will help you meet the testing requirements for this assignment as well.
model/rwby.js
Outdated
|
|
||
| Rwby.fetchRwby = function(id){ | ||
| debug('Fetch RWBY'); | ||
| storage.fetchItem('rwby', id); |
There was a problem hiding this comment.
You're missing 'return' for your fetchItem functionality. So try:
return storage.fetchItem('rwby', id);
route/rwby-router.js
Outdated
| .catch( err => next(err)); | ||
| }); | ||
|
|
||
| rwbyRouter.put('/api/rwby/:id', function(req, res, next){ |
There was a problem hiding this comment.
You're missing jsonParser middleware here: Try the following:
rwbyRouter.put('/api/rwby/:id', jsonParser, function(req, res, next){
There was a problem hiding this comment.
I'm sure you understand why we need this. If not, we can talk about it tomorrow, but in the meantime, this should also fix your post test.
test/rwby-route-test.js
Outdated
| } | ||
| }); | ||
| it(' should return a rwby', done => { | ||
| let updateRwby = {name :'new name', content : 'new content'}; |
There was a problem hiding this comment.
I'm assuming this was the part you copied from the lab, remember to have the appropriate parameters as such:
let updateRwby = { name: 'new name', weapon: 'new weapon', symbol: 'new symbol' };
test/rwby-route-test.js
Outdated
| }); | ||
| it(' should return a rwby', done => { | ||
| let updateRwby = {name :'new name', content : 'new content'}; | ||
| request.put(`${url}/api/rwby?id=${this.tempRwby.id}`) |
There was a problem hiding this comment.
Also, keep in mind that if you decide to use req.params.id, you need to format your endpoints differently as well:
request.put(${url}/api/rwby/${this.tempRwby.id})
For future reference:
req.params.id = /${id}
req.query.id = ?id=${id}
No description provided.