lab14-Jeremiah 11 Test Passing #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalleng
reviewed
Mar 5, 2017
| const lotSchema = Schema({ | ||
| name: { type: String, required: true }, | ||
| timestamp: { type: Date, required: true }, | ||
| cars: [{ type: Schema.Types.ObjectId, ref: 'car' }] |
There was a problem hiding this comment.
This can be confusing. Good job referencing the 'car' correctly here.
jalleng
reviewed
Mar 5, 2017
|
|
||
| Lot.findByIdAndAddCar(req.params.lotID, req.body) | ||
| .then( car => res.json(car)) | ||
| .catch( err => next(createError(404, err.message))); |
There was a problem hiding this comment.
Good job creating the error to send back.
jalleng
reviewed
Mar 5, 2017
|
|
||
| lotRouter.get('/api/lot/:id', function(req, res, next) { | ||
| Lot.findById(req.params.id) | ||
| .populate('cars') |
jalleng
reviewed
Mar 5, 2017
test/car-route-test.js
Outdated
| request.post(`${url}/api/lot`) | ||
| .send('stting') | ||
| .set('Content-Type', 'application/json') | ||
| .end((err, res)=> { |
There was a problem hiding this comment.
You have some funny indention going on here.
There was a problem hiding this comment.
I have to get in the habit of actually using my auto-indent atom package!
jalleng
reviewed
Mar 5, 2017
test/car-route-test.js
Outdated
| it('should return a 404 error', done => { | ||
| request.post(`${url}/api/lot/2345`) | ||
| .end((err, res) => { | ||
| expect(res.status).to.equal(404); |
There was a problem hiding this comment.
Make sure you are handling the possible err here.
jalleng
reviewed
Mar 5, 2017
test/car-route-test.js
Outdated
| describe('with an invalid id or none provided', function() { | ||
| it('should return a 404 error', done => { | ||
| request.post(`${url}/api/lot/2345`) | ||
| .end((err, res) => { |
jalleng
reviewed
Mar 5, 2017
test/car-route-test.js
Outdated
|
|
||
| it('should return a car', done => { | ||
| request.get( `${url}/api/car/${this.tempCar._id}`) | ||
| .end((err, res) => { |
jalleng
reviewed
Mar 5, 2017
test/car-route-test.js
Outdated
| describe('with an invalid id', function(){ | ||
| it('should return a 404', done => { | ||
| request.get(`${url}/api/car/6574`) | ||
| .end((err, res) =>{ |
jalleng
reviewed
Mar 5, 2017
| describe('with an invalid id or none provided', function() { | ||
| it('should return a 404 error', done => { | ||
| request.post(`${url}/api/lot/2345`) | ||
| .end((err, res) => { |
jalleng
reviewed
Mar 5, 2017
| describe('with an invalid body or none provided', function() { | ||
| it('should return a 400 error', done => { | ||
| request.post(`${url}/api/lot`) | ||
| .send('tdd makes me angry') |
jalleng
reviewed
Mar 5, 2017
|
|
||
| it('should return a lot', done => { | ||
| request.get( `${url}/api/lot/${this.tempLot._id}`) | ||
| .end((err, res) => { |
jalleng
reviewed
Mar 5, 2017
| var updated = { name: 'updated name' }; | ||
|
|
||
| request.put(`${url}/api/lot/${this.tempLot._id}`) | ||
| .send(updated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.