lab 18 Jeremiah #34
Open
lab 18 Jeremiah #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalleng
reviewed
Mar 10, 2017
| userID: { type: Schema.Types.ObjectId, required: true },//make sure its part of the correct gallery | ||
| galleryID: { type: Schema.Types.ObjectId, required: true }, | ||
| imageURI: { type: String, required: true, unique: true },//what comes back from s3 | ||
| objectKey: { type: String, required: true, unique: true },//also comes back from s3 |
There was a problem hiding this comment.
I like that you are taking notes to remind yourself what things are. I take notes in my code as well. Sometimes if I have questions I will note them in there as well and just remove them before pushing.
jalleng
reviewed
Mar 10, 2017
| debug('POST: /api/gallery'); | ||
|
|
||
| if(!req.body.name) return next(createError(400, 'no name')); | ||
| if(!req.body.desc) return next(createError(400, 'no description')); |
There was a problem hiding this comment.
Good job adding extra error checking in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.