Nikko Lab 22 #3
Open
Nikko Lab 22 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalleng
reviewed
Mar 23, 2017
app/entry.js
Outdated
| 'use strict'; | ||
|
|
||
| require('./scss/reset.scss'); | ||
| require('./scss/main.scss'); |
There was a problem hiding this comment.
You've renamed these but you are still requiring them here with the old name.
jalleng
reviewed
Mar 23, 2017
webpack.config.js
Outdated
| module.exports = { | ||
| entry: `${__dirname}/app/entry.js`, | ||
| output: { | ||
| file: 'bundle.js', |
There was a problem hiding this comment.
Something wrong with this line. See if you can figure out what it is.
jalleng
reviewed
Mar 23, 2017
| "node-sass": "^4.5.1", | ||
| "sass-loader": "^6.0.3", | ||
| "style-loader": "^0.16.0", | ||
| "webpack": "^1.14.0" |
There was a problem hiding this comment.
You are missing file-loader and url-loader.
There was a problem hiding this comment.
I don't remember using those dependencies? I was checking other peoples' package.json files and I didn't see them either?
There was a problem hiding this comment.
Brian had them in his and I thought that might be why your fonts were not loading.
jalleng
reviewed
Mar 23, 2017
| *~ | ||
|
|
||
| #Build (webpack) | ||
| build/ |
jalleng
reviewed
Mar 23, 2017
| @import 'base'; | ||
| @import 'main'; | ||
| @import 'nav'; | ||
| @import 'footer'; |
jalleng
reviewed
Mar 23, 2017
| "watch": "./node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot", | ||
| "test": "./node_modules/karma/bin/karma start --single", | ||
| "test-watch": "./node_modules/karma/bin/karma start", | ||
| "lint": "./node_modules/eslint/bin/eslint.js ./*" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.