Skip to content

lab-regan-32 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

lab-regan-32 #99

wants to merge 27 commits into from

Conversation

reganoneill
Copy link

No description provided.

@reganoneill
structure complete
56b30d8
@reganoneill
webpack hates svg
7ed2898
@reganoneill
layout complete
c85e205
@reganoneill
submitlab
08728bf
@reganoneill
log config and gallery service built
b53441d
@reganoneill
markdown and js mostly complete
8593b67
@reganoneill
mvp met
7d1ccb8
@reganoneill
landing refactor complete
fdac0d6
@reganoneill
minor revisions and additions needed
a2898c7
@reganoneill
core functionality
8b526c8
@reganoneill
fixed page load issue
34974f1
@reganoneill
angular dom manipulation
b970d72
@reganoneill
submission
d263391
@reganoneill
cleaned up home view
d409ee3
@reganoneill
basic image ups functionality
05eadab
@reganoneill
local deploy image upload working
73123fc
@reganoneill
committing for submission
9b6ad29
@reganoneill
basic test structure
4f16d59
@reganoneill
delete pic working
9e07f68
@reganoneill
submission
a4740f1
@reganoneill
update test works
229f429
@reganoneill
completed tests
ee46c88
@reganoneill
icons, custom directive, filter
a8a1b48
@reganoneill
reformatted and resized sprite sheet content
31b8010
@reganoneill
added native filter in thumbnail cont
82be9cc
@reganoneill
improved formatting
02f2477
@reganoneill
submission
f885325
jalleng
jalleng reviewed Apr 9, 2017
View reviewed changes
lab-regan/app/directive/_social-icons.scss
}
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job using the sprite sheet!

jalleng
jalleng reviewed Apr 9, 2017
View reviewed changes
lab-regan/app/directive/social-icons.html
<div class="social-media-icons">
<h3>{{socialIconsCtrl.tester}}</h3>
<ul>
<li><a class="social-icon" ng-repeat="icon in socialIconsCtrl.icons" href="{{icon}}.com"></a></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-This works with the ng-repeat. Another option would be to dynamically generate a class name in here from what is stored in your icons array.
-The href attribute will automatically append the attribute to the domain of your page unless you provide it with the new domain. So if your page is running on http://localhost:8000, and you provide a value of twitter.com in the href attribute, clicking on this element will send you to http://localhost:8000/twitter.com. Which is not a path that you have setup on your frontend. To get it to go to https://www.twitter.com you need to provide it with the https://www part. The https:// will tell it that you are providing an external link. So you could change the values in your array. Or if the links you wanted all had the same prefix you could do something like this-->> href='https://www.{{icon}}.com'.

jalleng
jalleng reviewed Apr 9, 2017
View reviewed changes
lab-regan/app/view/home/home.html
<section class="home">
<create-gallery></create-gallery>

<input class="fuzzy-input" ng-if="homeCtrl.galleries.length >= 5" type="text" placeholder="search for a gallery" ng-model="homeCtrl.gallerySearchTerm">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here.

jalleng
jalleng reviewed Apr 9, 2017
View reviewed changes
lab-regan/app/component/gallery/thumbnail-container/thumbnail-container.html
@@ -0,0 +1,7 @@
<div class="thumbnail-container">
<h3>{{thumbnailContainerCtrl.gallery.name | uppercase}}</h3>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jalleng jalleng jalleng left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reganoneill @jalleng