Upgrade #8
Open
Upgrade #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettchase
commented
Mar 8, 2024
rhettchase
commented
- did review of quick start and tested functionality
- upgrades whitenoise to 6.6.0
- upgrades djangorestframework-simplejwt to v 5.3.1 (Note: simplejwt is only compatible up to Django 4.2)
- fixes detail view template bug to correctly display reviewer
- updates create template to include description
- Note: Django REST Framework is not tested to be compatible with Django 5, so did NOT upgrade Django. Per DRF docs, latest compatibility is Django 4.1
rhettchase
commented
Jul 11, 2024
| @@ -29,8 +29,7 @@ <h5 class=" flex-auto mb-2 text-2xl font-bold tracking-tight text-gray-900 dark: | |||
|
|
|||
| </div> | |||
|
|
|||
| <h5 class=" flex-auto mb-2 text-md font-bold tracking-tight text-gray-900 dark:text-white">Reviewed by: {{ | |||
| thing.reviewer }}</h5> | |||
| <h5 class="flex-auto mb-2 font-bold tracking-tight text-gray-900 text-md dark:text-white">Reviewed by: {{ thing.reviewer.username }}</h5> | |||
There was a problem hiding this comment.
fixes formatting to display reviewers's username
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.