Skip to content

⚡️ Speed up method PropertyValueDict.clear by 8% #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
+5 −2
Open

⚡️ Speed up method PropertyValueDict.clear by 8% #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/bokeh/core/property/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,9 @@ class PropertyValueDict(PropertyValueContainer, dict[str, T_Val]):

"""
def __init__(self, *args, **kwargs) -> None:
super().__init__(*args, **kwargs)
# Avoid unnecessary double initialization by calling __init__ on PropertyValueContainer only
PropertyValueContainer.__init__(self)
dict.__init__(self, *args, **kwargs)

def _saved_copy(self):
return dict(self)
Expand All @@ -365,7 +367,8 @@ def __setitem__(self, i, y):

@notify_owner
def clear(self):
return super().clear()
# Use dict.clear directly to avoid potential overhead of super()
return dict.clear(self)

@notify_owner
def pop(self, *args):
Expand Down