Skip to content

migrate to uv #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

migrate to uv #57

wants to merge 8 commits into from

Conversation

KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Mar 17, 2025

PR Type

  • Enhancement

Description

  • Update version comment to reflect hatch-vcs usage

  • Replace Poetry configuration with Hatch configuration

  • Add comprehensive dependency and dev group definitions

  • Update build backend to hatchling and integrate version hooks


Changes walkthrough 📝

Relevant files
Enhancement
version.py
Update version file comment for build tool                             

codeflash/version.py

  • Changed comment from poetry-dynamic-versioning to hatch-vcs
  • Kept version constants unchanged
  • +1/-1     
    pyproject.toml
    Migrate build configuration from Poetry to Hatch                 

    pyproject.toml

  • Removed [tool.poetry] sections, introduced [project] block
  • Added new dependency list and dev dependency group
  • Integrated hatch build hooks and versioning configuration
  • Updated build backend from poetry-dynamic-versioning to hatchling
  • +75/-87 

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    License Format

    The license field appears to include unintended whitespace or tab characters, which might cause parsing issues. Please verify the formatting.

    license = "BUSL-1.1	"
    Configuration Update

    The newly added build-system hooks and versioning configuration (using hatch-vcs and hatchling) should be carefully reviewed to ensure they integrate seamlessly and replace the previous Poetry-based setup.

    [tool.hatch.build.hooks.vcs]
    version-file = "codeflash/version.py"
    
    [tool.hatch.version]
    source = "vcs"
    tag-pattern = "(?:^|^v|^release/)(?P<version>[0-9]+\\.[0-9]+\\.[0-9]+)$"
    

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Remove extra license whitespace

    Remove the extraneous whitespace from the license string to ensure proper parsing.

    pyproject.toml [7]

    -license = "BUSL-1.1	"
    +license = "BUSL-1.1"
    Suggestion importance[1-10]: 5

    __

    Why: The suggestion correctly identifies and removes unnecessary whitespace from the license string, enhancing formatting consistency without major functional impact.

    Low

    Copy link
    Contributor

    @Saga4 Saga4 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Test1

    Copy link
    Contributor

    @misrasaurabh1 misrasaurabh1 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Here is why you should make these changes. TEST

    echo ".git directory exists!"
    sudo rm -rf .git
    if [ -d ".git" ]; then
    echo ".git directory still exists after removal attempt!"
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    why is this removed? the .git part was part of the test

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants