Skip to content

⚡️ Speed up function maybe_wrap_in_iframe by 50% #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function maybe_wrap_in_iframe by 50% #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions marimo/_output/formatters/iframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
# Copyright 2025 Marimo. All rights reserved.
from __future__ import annotations

import re
from html.parser import HTMLParser

_SCRIPT_INLINE_RE = re.compile(
# matches <script ...> that does NOT have 'src=' before the close '>'
r"<script\b(?![^>]*\bsrc\s*=)",
re.IGNORECASE,
)


def maybe_wrap_in_iframe(html_content: str) -> str:
if _has_script_tag_without_src(html_content):
Expand All @@ -17,6 +24,10 @@ def _has_script_tag_without_src(html_content: str) -> bool:
if "<script" not in html_content:
return False

# Fast regex check for <script ...> without src
if not _SCRIPT_INLINE_RE.search(html_content):
return False

parser = ScriptTagParser()
try:
parser.feed(html_content) # type: ignore
Expand Down
5 changes: 2 additions & 3 deletions marimo/_output/formatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,8 @@ def get_formatter(
get_context()
except ContextNotInitializedError:
if FORMATTERS.is_empty():
from marimo._output.formatters.formatters import (
register_formatters,
)
from marimo._output.formatters.formatters import \
register_formatters

# Install formatters when marimo is being used without
# a kernel (eg, in a unit test or when run as a Python script)
Expand Down