Skip to content

⚡️ Speed up function memoize_last_value by 7% #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function memoize_last_value by 7% #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions marimo/_utils/memoize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,36 +14,27 @@ def memoize_last_value(func: Callable[..., T]) -> Callable[..., T]:
object identity for positional arguments instead of equality
which for functools requires the arguments to be hashable.
"""
last_input: tuple[tuple[Any, ...], frozenset[tuple[str, Any]]] = (
(),
frozenset(),
)
last_input_args: tuple[Any, ...] = ()
last_input_kwargs: frozenset[tuple[str, Any]] = frozenset()
last_output: T = cast(T, sentinel)

def wrapper(*args: Any, **kwargs: Any) -> T:
nonlocal last_input, last_output

current_input: tuple[tuple[Any, ...], frozenset[tuple[str, Any]]] = (
args,
frozenset(kwargs.items()),
)
nonlocal last_input_args, last_input_kwargs, last_output

if (
last_output is not sentinel
and len(current_input[0]) == len(last_input[0])
and len(args) == len(last_input_args)
and all(
current_input[0][i] is last_input[0][i]
for i in range(len(current_input[0]))
if i < len(last_input[0])
arg is last_arg for arg, last_arg in zip(args, last_input_args)
)
and current_input[1] == last_input[1]
and frozenset(kwargs.items()) == last_input_kwargs
):
assert last_output is not sentinel
return last_output

result: T = func(*args, **kwargs)

last_input = current_input
last_input_args = args
last_input_kwargs = frozenset(kwargs.items())
last_output = result

return result
Expand Down