Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new service fields exposed by the API #667

Closed
monfresh opened this issue Oct 23, 2014 · 2 comments
Closed

Add new service fields exposed by the API #667

monfresh opened this issue Oct 23, 2014 · 2 comments
Labels
in progress

Comments

@monfresh
Copy link
Member

Now that the API has been updated with the new Service fields, most should probably be exposed on the Location details page. Read the docs for the full list of Service fields.

Also, note that there is now a required status field for Services that can either be active, inactive, or defunct. This means that it should be checked so that only active services are displayed. Alternatively, inactive or defunct services could have special styling applied to them to indicate they are not active, but I think it's less confusing to just not show them at all.

In addition, because it's possible for all of a Location's services to be inactive or defunct, that Location should probably not appear in search results, and if it were to be visited directly, a message should be shown that this Location is now inactive. See this API commit for more details: codeforamerica/ohana-api@3f0357f
@anselmbradford
Copy link
Member

Also, note that there is now a required status field for Services that can either be active, inactive, or defunct. This means that it should be checked so that only active services are displayed. Alternatively, inactive or defunct services could have special styling applied to them to indicate they are not active, but I think it's less confusing to just not show them at all.

Perhaps hide them by adding the hide CSS class and have an inconspicuous "show inactive services" button that toggles displaying them, so that there's some explanation for why those services have disappeared.

@monfresh
Copy link
Member Author

monfresh commented Nov 1, 2014

As part of this update, just wanted to make sure we replace service.urls with service.website. A service now only has one website.

This was referenced Nov 5, 2014
Open
Merged
anselmbradford added a commit that referenced this issue Nov 11, 2014
@anselmbradford
Fixes #667 - adds new service fields exposed API
501e721 
- In order to organize the location details spec better, this commit
moves the location services tests to their own spec file.
- Orders service tests to fit the order shown in the detail view (with
the exception of the hours, which will be handled separately in
#671)
- Updates service_areas service partial name to be in the format field
name prefixed by `service_`, which follows the format of the other
partials. The file was named `service_areas`, which implies the field
is `areas`, when in fact, it is `service_areas`.
- Removes optional requirement from `how_to_apply` service field.
- Edits `name` and adds `alternate_name` service field and tests.
Removes optional check for the required `name` field.
- Adds test for service description field
and updates specificity of description test.
- Makes location description test check the description selector contents
as opposed to the whole page, since the checked content “Lorem Ipsum”
appears in the service description fields as well.
- Adds `email` service field and test.
- Renames `urls` service field to `website`, since a service now only has
one website. Also adds a test.
- Adds a container and styles for the parent element around `website` and
`email` service fields.
-Adds `accepted_payments` service field, locale, and test.
-Adds `required_documents` service field, locale, and test.
- Adds `status` service field and test.
- Renames name partial container and CSS from `title` to `name-box`.
anselmbradford added a commit that referenced this issue Nov 12, 2014
@anselmbradford
Fixes #667 - adds new service fields exposed API
e1078a6 
- In order to organize the location details spec better, this commit
moves the location services tests to their own spec file.
- Orders service tests to fit the order shown in the detail view (with
the exception of the hours, which will be handled separately in
#671)
- Updates service_areas service partial name to be in the format field
name prefixed by `service_`, which follows the format of the other
partials. The file was named `service_areas`, which implies the field
is `areas`, when in fact, it is `service_areas`.
- Removes optional requirement from `how_to_apply` service field.
- Edits `name` and adds `alternate_name` service field and tests.
Removes optional check for the required `name` field.
- Adds test for service description field
and updates specificity of description test.
- Makes location description test check the description selector contents
as opposed to the whole page, since the checked content “Lorem Ipsum”
appears in the service description fields as well.
- Adds `email` service field and test.
- Renames `urls` service field to `website`, since a service now only has
one website. Also adds a test.
- Adds a container and styles for the parent element around `website` and
`email` service fields.
-Adds `accepted_payments` service field, locale, and test.
-Adds `required_documents` service field, locale, and test.
- Adds `status` service field and test.
- Renames name partial container and CSS from `title` to `name-box`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anselmbradford @monfresh