This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Update Open311 endpoints with new SCF links #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'll take a look at what's failing in CI. |
|
@bensheldon Looks like "Macon" is missing from the cities list and there's a problem with Requests SSL? https://travis-ci.org/codeforamerica/three/jobs/124831765 |
|
Whoah a @zachwill sighting! |
|
I deleted the Macon entry as we don't have an endpoint that corresponds precisely to Macon anymore, looks like a test was relying on that entry specifically. Also swapped the links to use https, is http required here? |
|
@zdicesare, you'll need to commit the changes you made … |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URLs for the SeeClickFix Open311 endpoints that were listed in
cities.pywere linking to our old endpoints and broken. I'm an employee of SCF and have updated the list to point to each location's new SCF open311 endpoint, and deleted the ones that don't have an account ID to query by.