Fyst 1516 add email validation step to prior year access flow #5300

DrewProebstel · 2024-12-30T15:01:26Z

Link to pivotal/JIRA issue

-https://codeforamerica.atlassian.net/browse/FYST-1516

Is PM acceptance required? (delete one)

Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

adds the State_File_Archive_Intake State_File_Archive_Access_Log and State_File_Archive_Request models
adds a link in the about page for the get your pdf flow
adds feature flags for the new flow
adds email address page
adds verification code page

How to test?

Describe the testing approach taken to verify the changes, including:
- Hop on demo and test out the flow
Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
Risk Assessment
- Risks or side effects associated with the changes and how they were mitigated.
- Highlight areas that may need extra attention during code review or testing.
- Paste SQL queries or output where relevant

Screenshots (for visual changes)

TODO:
Make something more beautiful than this in app/jobs/archived_intake_email_verification_code_job.rb

def priority
    PRIORITY_HIGH - 1
end

github-actions · 2024-12-30T15:06:02Z

Heroku app: https://gyr-review-app-5300-d758a122588b.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5300 (optionally add --tail)

Co-authored-by: Drew Proebstel <dproebstel@codeforamerica.org>

…" (#5317) This reverts commit f1e5246. Co-authored-by: Drew Proebstel <dproebstel@codeforamerica.org>

… into FYST-1516-add-email-validation-step-to-prior-year-access-flow

…access-mvp

db/schema.rb

app/controllers/state_file/archived_intakes/verification_code_controller.rb

* Add last year verification email Co-authored-by: Em Barnard-Shao <ebarnard@codeforamerica.org> Co-authored-by: Hugo Melo <hmelo@codeforamerica.org> * Rename previous year to archived intake Co-authored-by: Hugo Melo <hmelo@codeforamerica.org> * normalize Co-authored-by: Hugo Melo <hmelo@codeforamerica.org> --------- Co-authored-by: Em Barnard-Shao <ebarnard@codeforamerica.org>

…il-validation-step-to-prior-year-access-flow

app/models/state_file_archived_intake_request.rb

app/services/archived_intake_email_verification_code_service.rb

app/views/state_file/state_file_pages/about_page.html.erb

db/migrate/20250108221853_state_file_archived_intake_requests.rb

db/migrate/20250113222716_remove_state_file_archived_intake_requests_fields.rb

spec/features/state_file/prior_year_access_spec.rb

db/schema.rb

spec/features/state_file/prior_year_access_spec.rb

anisharamnani · 2025-01-14T16:09:06Z

app/jobs/archived_intake_email_verification_code_job.rb

+  end
+
+  def perform(email_address:, locale:)
+    ArchivedIntakeEmailVerificationCodeService.request_code(email_address: email_address, locale: locale)


[pebble] also i wanted to point out here, if you're renaming this file in your PR, you'd want to delete the old one too. i don't see that happening in the PR.

fixed this!

…alidation-step-to-prior-year-access-flow

app/views/state_file/state_file_pages/about_page.html.erb

config/routes.rb

arinchoi03 · 2025-01-14T17:46:04Z

spec/controllers/state_file/archived_intake/archived_intake_controller_spec.rb

+      expect(result).to be_a(StateFileArchivedIntakeAccessLog)
+      expect(result.event_type).to eq event_type
+      expect(result.state_file_archived_intake_request).to eq request_instance
+    end


[pebble] can we add an expectation testing what would happen if current_request is nil since that's a potential outcome? I'm guessing it creates an access log the same way with nil as the state_file_archived_intake_request_id on that record, since there's no NOT NULL constraint

arinchoi03

lgtm! just a small nitpicks/pebble

jenny-heath

great job!

…s-flow' of github.com:codeforamerica/vita-min into FYST-1516-add-email-validation-step-to-prior-year-access-flow

jnf and others added 10 commits December 27, 2024 12:01

i don't know why i had to do this

30dd34b

can navigate to email address page

2d1f3f1

rename files and add link

36a8be4

delete unused controller

eb43c45

remove unused data migration

ca18535

i18n health

a8ad9db

intake archiving (models and migrations) (#5299)

1cfc369

wip

5b22894

merge in migrations

a32e759

wip

a0969e3

DrewProebstel and others added 7 commits December 30, 2024 18:26

Fyst 1515 add prior year access link button to homepage (#5296)

f1e5246

Co-authored-by: Drew Proebstel <dproebstel@codeforamerica.org>

wip

234b1e3

Merge branch 'main' into FYST-1466-prior-year-access-mvp

1b95140

email form is not using questions controller

0798ab6

update unused file

4181a66

remove unused prys

5162bf6

pages navigate

c39a237

anisharamnani changed the base branch from main to FYST-1466-prior-year-access-mvp January 6, 2025 20:30

DrewProebstel and others added 5 commits January 6, 2025 13:03

Revert "Fyst 1515 add prior year access link button to homepage (#5296)…

be8795e

…" (#5317) This reverts commit f1e5246. Co-authored-by: Drew Proebstel <dproebstel@codeforamerica.org>

Merge remote-tracking branch 'origin/FYST-1466-prior-year-access-mvp'…

e7d479c

… into FYST-1516-add-email-validation-step-to-prior-year-access-flow

delete unused views

90da001

Merge remote-tracking branch 'origin/main' into FYST-1466-prior-year-…

10b64ec

…access-mvp

some tests

e3be6ee

anisharamnani reviewed Jan 7, 2025

View reviewed changes

db/schema.rb Outdated Show resolved Hide resolved

update schema

4bc1aaf

anisharamnani reviewed Jan 7, 2025

View reviewed changes

app/controllers/state_file/archived_intakes/verification_code_controller.rb Show resolved Hide resolved

squanto and others added 3 commits January 7, 2025 16:04

wip

32803b9

Merge branch 'FYST-1466-prior-year-access-mvp' into FYST-1516-add-ema…

9b26ce6

…il-validation-step-to-prior-year-access-flow