Fyst -520 archived intake pdf download screen #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squanto
force-pushed
the
FYST-1520-pdf-download-screen
branch
from
3ab00a7 to
6975caa
Compare
|
Heroku app: https://gyr-review-app-5399-d3511315f7b8.herokuapp.com/ |
mrotondo
reviewed
Jan 23, 2025
| @@ -11,6 +11,7 @@ | |||
| Flipper.disable :show_retirement_ui unless Flipper.exist?(:show_retirement_ui) | |||
| Flipper.disable :sms_notifications unless Flipper.exist?(:sms_notifications) | |||
| Flipper.disable :hub_dashboard unless Flipper.exist?(:hub_dashboard) | |||
| Flipper.disable :get_your_pdf unless Flipper.exist?(:get_your_pdf) | |||
squanto
force-pushed
the
FYST-1520-pdf-download-screen
branch
2 times, most recently
from
ccf9c8c to
6b5ae81
Compare
mrotondo
approved these changes
Jan 24, 2025
tahsinaislam
approved these changes
Jan 27, 2025
| return if session[:mailing_verified].present? | ||
|
|
||
| redirect_to root_path | ||
| end |
There was a problem hiding this comment.
could all this before actions be in one method if they all redirect to root path?
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
squanto
force-pushed
the
FYST-1520-pdf-download-screen
branch
from
d4219e3 to
e83fc5d
Compare
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-1520
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
TODO
This can't be properly tested until verify ssn and other login stories are merged to step through the archive intake download flow