NJ 271 - fix when review screen displays health insurance section

app/controllers/state_file/questions/nj_dependents_health_insurance_controller.rb

@@ -4,8 +4,7 @@ class NjDependentsHealthInsuranceController < QuestionsController
       include ReturnToReviewConcern
 
       def self.show?(intake)
-        return false unless intake.dependents.any?
-        intake.has_health_insurance_requirement_exception? || intake.eligibility_all_members_health_insurance_no?
+        intake.dependents.any? && intake.has_health_insurance_requirement_exception?
       end
 
       def form_params

app/views/state_file/questions/nj_review/edit.html.erb

@@ -23,7 +23,7 @@
     </section>
   <% end %>
 
-  <% if current_intake.has_health_insurance_requirement_exception? || current_intake.eligibility_all_members_health_insurance_no? %>
+  <% if current_intake.dependents.any? && current_intake.has_health_insurance_requirement_exception? %>
     <section id="missing-health-insurance" class="white-group">
       <div class="spacing-below-5">
         <h2 class="text--body text--bold spacing-below-5"><%=t(".missing_health_insurance") %></h2>

spec/controllers/state_file/questions/nj_dependents_health_insurance_controller_spec.rb

@@ -29,14 +29,6 @@
           expect(described_class.show?(intake)).to eq true
         end
       end
-
-      context "and did not have a health insurance requirement exception, but all members did not have health insurance" do  
-        it "shows" do
-          allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return(false)
-          allow_any_instance_of(StateFileNjIntake).to receive(:eligibility_all_members_health_insurance_no?).and_return(true)
-          expect(described_class.show?(intake)).to eq true
-        end
-      end
     end
   end
 

spec/controllers/state_file/questions/nj_review_controller_spec.rb

@@ -0,0 +1,39 @@
+require "rails_helper"
+
+RSpec.describe StateFile::Questions::NjReviewController do
+  before do
+    sign_in intake
+  end
+
+  describe "#edit" do
+    render_views
+    context 'when no dependents' do
+      let(:intake) { create :state_file_nj_intake, :df_data_no_deps }
+
+      it 'does not show the dependents without health insurance block' do
+        allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return false
+        get :edit
+        expect(response.body).not_to have_text "Dependents who DO NOT have health insurance"
+      end
+    end
+
+    context 'when taxpayer has dependents' do
+      let(:intake) { create :state_file_nj_intake, :df_data_qss }
+      context 'when taxpayer does not have health insurance exception' do
+        it 'does not show the dependents without health insurance block' do
+          allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return false
+          get :edit
+          expect(response.body).not_to have_text "Dependents who DO NOT have health insurance"
+        end
+      end
+
+      context 'when taxpayer does have health insurance exception' do
+        it 'shows the dependents without health insurance block' do
+          allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return true
+          get :edit
+          expect(response.body).to have_text "Dependents who DO NOT have health insurance"
+        end
+      end
+    end
+  end
+end

spec/factories/state_file_nj_intakes.rb

@@ -128,14 +128,6 @@
 
     after(:build) do |intake, evaluator|
       intake.municipality_code = "0101"
-      numeric_status = {
-        single: 1,
-        married_filing_jointly: 2,
-        married_filing_separately: 3,
-        head_of_household: 4,
-        qualifying_widow: 5,
-        }[evaluator.filing_status.to_sym] || evaluator.filing_status
-      intake.direct_file_data.filing_status = numeric_status
       intake.direct_file_data.primary_ssn = evaluator.primary_ssn || intake.direct_file_data.primary_ssn
       intake.direct_file_data.spouse_ssn = evaluator.spouse_ssn || intake.direct_file_data.spouse_ssn
       intake.raw_direct_file_data = intake.direct_file_data.to_s
@@ -178,6 +170,11 @@
       raw_direct_file_intake_data { StateFile::DirectFileApiResponseSampleService.new.read_json('nj_minimal') }
     end
 
+    trait :df_data_no_deps do
+      raw_direct_file_data { StateFile::DirectFileApiResponseSampleService.new.read_xml('nj_springsteen_mfj') }
+      raw_direct_file_intake_data { StateFile::DirectFileApiResponseSampleService.new.read_json('nj_springsteen_mfj') }
+    end
+
     trait :df_data_many_deps do
       raw_direct_file_data { StateFile::DirectFileApiResponseSampleService.new.read_xml('nj_zeus_many_deps') }
       raw_direct_file_intake_data { StateFile::DirectFileApiResponseSampleService.new.read_json('nj_zeus_many_deps') }