[FYST-1727] special program az #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5473-b680c13da290.herokuapp.com/ |
jnf
removed
the
wip
jnf
commented
Jan 29, 2025
| @@ -185,6 +187,10 @@ def schema_file | |||
| SchemaFileLoader.load_file("us_states", "unpacked", "AZIndividual2024v2.0", "AZIndividual", "IndividualReturnAZ140.xsd") | |||
| end | |||
|
|
|||
| def special_program | |||
| "<SpecialProgram>Direct File</SpecialProgram>" | |||
There was a problem hiding this comment.
i dunno if there's a fancy way to do this, but this works.
There was a problem hiding this comment.
I think it would be something kinda ridiculous like
Nokogiri::XML::Builder.new(encoding: 'UTF-8').send("SpecialProgram", "Direct File")
what you have is probably more clear
mpidcock
approved these changes
Jan 29, 2025
| @@ -185,6 +187,10 @@ def schema_file | |||
| SchemaFileLoader.load_file("us_states", "unpacked", "AZIndividual2024v2.0", "AZIndividual", "IndividualReturnAZ140.xsd") | |||
| end | |||
|
|
|||
| def special_program | |||
| "<SpecialProgram>Direct File</SpecialProgram>" | |||
There was a problem hiding this comment.
I think it would be something kinda ridiculous like
Nokogiri::XML::Builder.new(encoding: 'UTF-8').send("SpecialProgram", "Direct File")
what you have is probably more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
FYST-1727
Is PM acceptance required? (delete one)
Yes - don't merge until JIRA issue is accepted!
What was done?
SpecialProgramis an optional node that has remain unused; AZ folks asked if we could start including it to help them in their record keeping/stat building.How to test?
<SpecialProgram>Direct File</SpecialProgram>right after<ReturnType>in the<ReturnHeaderState>block.<SpecialProgram>